From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Streetman <ddstreet@ieee.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: z3fold: suspicious return with spinlock held
Date: Sat, 11 Mar 2017 00:22:12 +0300 [thread overview]
Message-ID: <1489180932-13918-1-git-send-email-khoroshilov@ispras.ru> (raw)
Hello!
z3fold_reclaim_page() contains the only return that may
leave the function with pool->lock spinlock held.
669 spin_lock(&pool->lock);
670 if (kref_put(&zhdr->refcount, release_z3fold_page)) {
671 atomic64_dec(&pool->pages_nr);
672 return 0;
673 }
May be we need spin_unlock(&pool->lock); just before return?
Found by Linux Driver Verification project (linuxtesting.org).
--
Thank you,
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-03-10 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 21:22 Alexey Khoroshilov [this message]
2017-03-10 21:34 ` Matthew Wilcox
2017-03-10 21:54 ` Alexey Khoroshilov
2017-03-10 22:08 ` vitalywool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489180932-13918-1-git-send-email-khoroshilov@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox