From: Eric Dumazet <eric.dumazet@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: Christoph Lameter <cl@linux.com>,
willy@infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org
Subject: Re: [PATCH RFC] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU
Date: Wed, 25 Jan 2017 14:46:17 -0800 [thread overview]
Message-ID: <1485384377.5145.77.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20170125200708.GG3989@linux.vnet.ibm.com>
On Wed, 2017-01-25 at 12:07 -0800, Paul E. McKenney wrote:
> On Wed, Jan 25, 2017 at 09:04:47AM -0800, Eric Dumazet wrote:
> >
> > Not clear why we need to change this very fine name ?
> >
> > SLAB_DESTROY_BY_RCU was only used by few of us, we know damn well what
> > it means.
> >
> > Consider we wont be able to change it in various web pages / archives /
> > changelogs.
>
> The reason I proposed this change is that I ran into some people last
> week who had burned some months learning that this very fine flag
> provides only type safety, not identity safety.
>
> Other proposals?
Bung hunting requires scrapping git log, in particular in areas touching
RCU (not exactly trivial stuff :) :) :) )
git log | grep SLAB_DESTROY_BY_RCU
A Google search on SLAB_DESTROY_BY_RCU finds ~4600 results.
If we rename SLAB_DESTROY_BY_RCU by XXXXXXXX, someone trying to see
prior patches or articles about XXXXXXXX mistakes will find nothing.
So please leave comments giving the old name ( SLAB_DESTROY_BY_RCU ) and
save time for future hackers.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-25 22:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 11:07 Paul E. McKenney
2017-01-18 11:12 ` willy
2017-01-18 22:17 ` Paul E. McKenney
2017-01-19 0:00 ` Christoph Lameter
2017-01-23 0:46 ` Paul E. McKenney
2017-01-25 16:45 ` Christoph Lameter
2017-01-25 17:04 ` Eric Dumazet
2017-01-25 20:07 ` Paul E. McKenney
2017-01-25 22:46 ` Eric Dumazet [this message]
2017-01-25 23:05 ` Paul E. McKenney
2017-01-25 20:25 ` Johannes Weiner
2017-01-25 21:26 ` Vlastimil Babka
2017-01-25 22:35 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485384377.5145.77.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox