From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBC4C433F5 for ; Tue, 26 Apr 2022 15:12:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21F506B0078; Tue, 26 Apr 2022 11:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DBA76B007B; Tue, 26 Apr 2022 11:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0233D6B007E; Tue, 26 Apr 2022 11:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id E533B6B0078 for ; Tue, 26 Apr 2022 11:12:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B19C6266A2 for ; Tue, 26 Apr 2022 15:12:35 +0000 (UTC) X-FDA: 79399371870.20.DE9DCCA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf02.hostedemail.com (Postfix) with ESMTP id 5338F80054 for ; Tue, 26 Apr 2022 15:12:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 884381F388; Tue, 26 Apr 2022 15:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1650985953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ilqNI6bkLcv0GvaJ4q+HJDdDtII/9oekltf7dQ89U9Q=; b=mdJ1KGIHs4YiMxBMHho6GPV5nZqr5jlYCgkOB4AePzlZRpANqXVYFptdb/aNuRB3aD4kj/ JnLWcxK5t7HMSY5fqQFmVLFk/Im+b4p+TKbJ/w+EoqzvV9FQzj1aR84NhLQCBb+B4g6kha e2HBxErTfMOCG3AoTvFbqOjrqV3jBfw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1650985953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ilqNI6bkLcv0GvaJ4q+HJDdDtII/9oekltf7dQ89U9Q=; b=AQoCjGFKfzfwH1TlMeEMeRZUDBhzeYSzTBgdOWde+6cgvfmcwbhLV5CEDdifooxTr7jeaZ zWY/tutiR8jcg2AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 335FF13AD5; Tue, 26 Apr 2022 15:12:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IIraC+ELaGIkXwAAMHmgww (envelope-from ); Tue, 26 Apr 2022 15:12:33 +0000 Message-ID: <147b11c3-dbce-ccd3-3b0c-c5971135f949@suse.cz> Date: Tue, 26 Apr 2022 17:12:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: kernel test robot , Peter Collingbourne , Andrey Konovalov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Catalin Marinas Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , penberg@kernel.org, roman.gushchin@linux.dev, iamjoonsoo.kim@lge.com, rientjes@google.com, Herbert Xu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev , Eric Biederman , Kees Cook References: <20220422201830.288018-1-pcc@google.com> <202204251346.WbwgrNZw-lkp@intel.com> From: Vlastimil Babka Subject: Re: [PATCH v3] mm: make minimum slab alignment a runtime property In-Reply-To: <202204251346.WbwgrNZw-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5338F80054 X-Stat-Signature: x3e3hd8kddm844gf9zwawcfwyi8fxgq1 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mdJ1KGIH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AQoCjGFK; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-HE-Tag: 1650985952-783190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/25/22 07:12, kernel test robot wrote: > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024 > base: https://github.com/hnaz/linux-mm master > config: arm64-buildonly-randconfig-r002-20220425 (https://download.01.org/0day-ci/archive/20220425/202204251346.WbwgrNZw-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/3aef97055dd4a480e05dff758164f153aaddbb49 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024 > git checkout 3aef97055dd4a480e05dff758164f153aaddbb49 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 prepare > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from kernel/bounds.c:10: > In file included from include/linux/page-flags.h:10: > In file included from include/linux/bug.h:5: > In file included from arch/arm64/include/asm/bug.h:26: > In file included from include/asm-generic/bug.h:22: > In file included from include/linux/printk.h:9: > In file included from include/linux/cache.h:6: > In file included from arch/arm64/include/asm/cache.h:56: > In file included from include/linux/kasan-enabled.h:5: > In file included from include/linux/static_key.h:1: Hmm looks like a circular include, cache.h is too "low-level" in the hierarchy to bring in kasan->static_key->jump_label.h definitions? jump_label.h does include bug.h, but we have it above already and have already passed #define _LINUX_BUG_H. So, a different kind of header with arm64-specific variant? >>> include/linux/jump_label.h:285:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > STATIC_KEY_CHECK_USE(key); > ^ > include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE' > #define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \ > ^ > include/linux/jump_label.h:291:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > STATIC_KEY_CHECK_USE(key); > ^ > include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE' > #define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \ > ^ > include/linux/jump_label.h:313:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > STATIC_KEY_CHECK_USE(key); > ^ > include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE' > #define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \ > ^ >>> include/linux/jump_label.h:316:3: error: call to undeclared function 'WARN_ON_ONCE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > WARN_ON_ONCE(atomic_read(&key->enabled) != 1); > ^ > include/linux/jump_label.h:324:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > STATIC_KEY_CHECK_USE(key); > ^ > include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE' > #define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \ > ^ > include/linux/jump_label.h:327:3: error: call to undeclared function 'WARN_ON_ONCE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > WARN_ON_ONCE(atomic_read(&key->enabled) != 0); > ^ > 6 errors generated. > make[2]: *** [scripts/Makefile.build:122: kernel/bounds.s] Error 1 > make[2]: Target '__build' not remade because of errors. > make[1]: *** [Makefile:1283: prepare0] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:226: __sub-make] Error 2 > make: Target 'prepare' not remade because of errors. > > > vim +/WARN +285 include/linux/jump_label.h > > bf5438fca2950b Jason Baron 2010-09-17 282 > c5905afb0ee655 Ingo Molnar 2012-02-24 283 static inline void static_key_slow_inc(struct static_key *key) > d430d3d7e646eb Jason Baron 2011-03-16 284 { > 5cdda5117e125e Borislav Petkov 2017-10-18 @285 STATIC_KEY_CHECK_USE(key); > d430d3d7e646eb Jason Baron 2011-03-16 286 atomic_inc(&key->enabled); > d430d3d7e646eb Jason Baron 2011-03-16 287 } > bf5438fca2950b Jason Baron 2010-09-17 288 > c5905afb0ee655 Ingo Molnar 2012-02-24 289 static inline void static_key_slow_dec(struct static_key *key) > bf5438fca2950b Jason Baron 2010-09-17 290 { > 5cdda5117e125e Borislav Petkov 2017-10-18 291 STATIC_KEY_CHECK_USE(key); > d430d3d7e646eb Jason Baron 2011-03-16 292 atomic_dec(&key->enabled); > bf5438fca2950b Jason Baron 2010-09-17 293 } > bf5438fca2950b Jason Baron 2010-09-17 294 > ce48c146495a1a Peter Zijlstra 2018-01-22 295 #define static_key_slow_inc_cpuslocked(key) static_key_slow_inc(key) > ce48c146495a1a Peter Zijlstra 2018-01-22 296 #define static_key_slow_dec_cpuslocked(key) static_key_slow_dec(key) > ce48c146495a1a Peter Zijlstra 2018-01-22 297 > 4c3ef6d79328c0 Jason Baron 2010-09-17 298 static inline int jump_label_text_reserved(void *start, void *end) > 4c3ef6d79328c0 Jason Baron 2010-09-17 299 { > 4c3ef6d79328c0 Jason Baron 2010-09-17 300 return 0; > 4c3ef6d79328c0 Jason Baron 2010-09-17 301 } > 4c3ef6d79328c0 Jason Baron 2010-09-17 302 > 91bad2f8d30574 Jason Baron 2010-10-01 303 static inline void jump_label_lock(void) {} > 91bad2f8d30574 Jason Baron 2010-10-01 304 static inline void jump_label_unlock(void) {} > 91bad2f8d30574 Jason Baron 2010-10-01 305 > d430d3d7e646eb Jason Baron 2011-03-16 306 static inline int jump_label_apply_nops(struct module *mod) > d430d3d7e646eb Jason Baron 2011-03-16 307 { > d430d3d7e646eb Jason Baron 2011-03-16 308 return 0; > d430d3d7e646eb Jason Baron 2011-03-16 309 } > b202952075f626 Gleb Natapov 2011-11-27 310 > e33886b38cc82a Peter Zijlstra 2015-07-24 311 static inline void static_key_enable(struct static_key *key) > e33886b38cc82a Peter Zijlstra 2015-07-24 312 { > 5cdda5117e125e Borislav Petkov 2017-10-18 313 STATIC_KEY_CHECK_USE(key); > e33886b38cc82a Peter Zijlstra 2015-07-24 314 > 1dbb6704de91b1 Paolo Bonzini 2017-08-01 315 if (atomic_read(&key->enabled) != 0) { > 1dbb6704de91b1 Paolo Bonzini 2017-08-01 @316 WARN_ON_ONCE(atomic_read(&key->enabled) != 1); > 1dbb6704de91b1 Paolo Bonzini 2017-08-01 317 return; > 1dbb6704de91b1 Paolo Bonzini 2017-08-01 318 } > 1dbb6704de91b1 Paolo Bonzini 2017-08-01 319 atomic_set(&key->enabled, 1); > e33886b38cc82a Peter Zijlstra 2015-07-24 320 } > e33886b38cc82a Peter Zijlstra 2015-07-24 321 >