From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by kanga.kvack.org (Postfix) with ESMTP id 2EABD6B025F for ; Fri, 8 Nov 2013 20:18:29 -0500 (EST) Received: by mail-pb0-f41.google.com with SMTP id wy17so2896757pbc.14 for ; Fri, 08 Nov 2013 17:18:28 -0800 (PST) Received: from psmtp.com ([74.125.245.180]) by mx.google.com with SMTP id gl1si8671301pac.24.2013.11.08.17.18.24 for ; Fri, 08 Nov 2013 17:18:25 -0800 (PST) From: "Rafael J. Wysocki" Subject: Re: [PATCH 13/24] mm/power: Use memblock apis for early memory allocations Date: Sat, 09 Nov 2013 02:30:44 +0100 Message-ID: <1479529.EjZ9YN8f8I@vostro.rjw.lan> In-Reply-To: <1383954120-24368-14-git-send-email-santosh.shilimkar@ti.com> References: <1383954120-24368-1-git-send-email-santosh.shilimkar@ti.com> <1383954120-24368-14-git-send-email-santosh.shilimkar@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: owner-linux-mm@kvack.org List-ID: To: Santosh Shilimkar Cc: tj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Yinghai Lu , Andrew Morton , Pavel Machek , linux-pm@vger.kernel.org On Friday, November 08, 2013 06:41:49 PM Santosh Shilimkar wrote: > Switch to memblock interfaces for early memory allocator instead of > bootmem allocator. No functional change in beahvior than what it is > in current code from bootmem users points of view. > > Archs already converted to NO_BOOTMEM now directly use memblock > interfaces instead of bootmem wrappers build on top of memblock. And the > archs which still uses bootmem, these new apis just fallback to exiting > bootmem APIs. > > Cc: Yinghai Lu > Cc: Tejun Heo > Cc: Andrew Morton > Cc: Pavel Machek > Cc: "Rafael J. Wysocki" > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Santosh Shilimkar Fine by me, thanks! > --- > kernel/power/snapshot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c > index 358a146..887134e 100644 > --- a/kernel/power/snapshot.c > +++ b/kernel/power/snapshot.c > @@ -637,7 +637,7 @@ __register_nosave_region(unsigned long start_pfn, unsigned long end_pfn, > BUG_ON(!region); > } else > /* This allocation cannot fail */ > - region = alloc_bootmem(sizeof(struct nosave_region)); > + region = memblock_virt_alloc(sizeof(struct nosave_region)); > region->start_pfn = start_pfn; > region->end_pfn = end_pfn; > list_add_tail(®ion->list, &nosave_regions); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org