From: Jan Kara <jack@suse.cz>
To: linux-mm@kvack.org
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
Andrew Morton <akpm@linux-foundation.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Jan Kara <jack@suse.cz>
Subject: [PATCH 04/21] mm: Use passed vm_fault structure in __do_fault()
Date: Fri, 4 Nov 2016 05:25:00 +0100 [thread overview]
Message-ID: <1478233517-3571-5-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1478233517-3571-1-git-send-email-jack@suse.cz>
Instead of creating another vm_fault structure, use the one passed to
__do_fault() for passing arguments into fault handler.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
mm/memory.c | 25 ++++++++++---------------
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 3b79eace8d23..8145dadb2645 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2852,37 +2852,31 @@ static int __do_fault(struct vm_fault *vmf, struct page *cow_page,
struct page **page, void **entry)
{
struct vm_area_struct *vma = vmf->vma;
- struct vm_fault vmf2;
int ret;
- vmf2.address = vmf->address;
- vmf2.pgoff = vmf->pgoff;
- vmf2.flags = vmf->flags;
- vmf2.page = NULL;
- vmf2.gfp_mask = __get_fault_gfp_mask(vma);
- vmf2.cow_page = cow_page;
+ vmf->cow_page = cow_page;
- ret = vma->vm_ops->fault(vma, &vmf2);
+ ret = vma->vm_ops->fault(vma, vmf);
if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))
return ret;
if (ret & VM_FAULT_DAX_LOCKED) {
- *entry = vmf2.entry;
+ *entry = vmf->entry;
return ret;
}
- if (unlikely(PageHWPoison(vmf2.page))) {
+ if (unlikely(PageHWPoison(vmf->page))) {
if (ret & VM_FAULT_LOCKED)
- unlock_page(vmf2.page);
- put_page(vmf2.page);
+ unlock_page(vmf->page);
+ put_page(vmf->page);
return VM_FAULT_HWPOISON;
}
if (unlikely(!(ret & VM_FAULT_LOCKED)))
- lock_page(vmf2.page);
+ lock_page(vmf->page);
else
- VM_BUG_ON_PAGE(!PageLocked(vmf2.page), vmf2.page);
+ VM_BUG_ON_PAGE(!PageLocked(vmf->page), vmf->page);
- *page = vmf2.page;
+ *page = vmf->page;
return ret;
}
@@ -3579,6 +3573,7 @@ static int __handle_mm_fault(struct vm_area_struct *vma, unsigned long address,
.address = address,
.flags = flags,
.pgoff = linear_page_index(vma, address),
+ .gfp_mask = __get_fault_gfp_mask(vma),
};
struct mm_struct *mm = vma->vm_mm;
pgd_t *pgd;
--
2.6.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-04 4:25 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 4:24 [PATCH 0/21 v4 RESEND] dax: Clear dirty bits after flushing caches Jan Kara
2016-11-04 4:24 ` [PATCH 01/21] mm: Join struct fault_env and vm_fault Jan Kara
2016-11-15 21:50 ` Kirill A. Shutemov
2016-11-16 10:51 ` Peter Zijlstra
2016-11-16 11:01 ` Jan Kara
2016-11-16 17:21 ` Peter Zijlstra
2016-11-17 9:07 ` Jan Kara
2016-11-16 11:13 ` Kirill A. Shutemov
2016-11-04 4:24 ` [PATCH 02/21] mm: Use vmf->address instead of of vmf->virtual_address Jan Kara
2016-11-15 21:55 ` Kirill A. Shutemov
2016-11-16 11:05 ` Jan Kara
2016-11-16 11:32 ` Kirill A. Shutemov
2016-11-16 11:55 ` Jan Kara
2016-11-04 4:24 ` [PATCH 03/21] mm: Use pgoff in struct vm_fault instead of passing it separately Jan Kara
2016-11-15 22:01 ` Kirill A. Shutemov
2016-11-04 4:25 ` Jan Kara [this message]
2016-11-15 22:05 ` [PATCH 04/21] mm: Use passed vm_fault structure in __do_fault() Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 05/21] mm: Trim __do_fault() arguments Jan Kara
2016-11-15 22:10 ` Kirill A. Shutemov
2016-11-16 13:12 ` Jan Kara
2016-11-04 4:25 ` [PATCH 06/21] mm: Use passed vm_fault structure for in wp_pfn_shared() Jan Kara
2016-11-15 22:10 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 07/21] mm: Add orig_pte field into vm_fault Jan Kara
2016-11-15 22:14 ` Kirill A. Shutemov
2016-11-16 20:00 ` Ross Zwisler
2016-11-04 4:25 ` [PATCH 08/21] mm: Allow full handling of COW faults in ->fault handlers Jan Kara
2016-11-15 22:20 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 09/21] mm: Factor out functionality to finish page faults Jan Kara
2016-11-15 22:21 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 10/21] mm: Move handling of COW faults into DAX code Jan Kara
2016-11-15 22:22 ` Kirill A. Shutemov
2016-11-16 21:28 ` Ross Zwisler
2016-11-17 9:36 ` Jan Kara
2016-11-04 4:25 ` [PATCH 11/21] mm: Remove unnecessary vma->vm_ops check Jan Kara
2016-11-15 22:28 ` Kirill A. Shutemov
2016-11-16 13:29 ` Jan Kara
2016-11-16 14:27 ` Kirill A. Shutemov
2016-11-16 14:43 ` Jan Kara
2016-11-04 4:25 ` [PATCH 12/21] mm: Factor out common parts of write fault handling Jan Kara
2016-11-15 22:30 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 13/21] mm: Pass vm_fault structure into do_page_mkwrite() Jan Kara
2016-11-15 22:40 ` Kirill A. Shutemov
2016-11-16 13:34 ` Jan Kara
2016-11-04 4:25 ` [PATCH 14/21] mm: Use vmf->page during WP faults Jan Kara
2016-11-15 22:42 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 15/21] mm: Move part of wp_page_reuse() into the single call site Jan Kara
2016-11-15 22:44 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 16/21] mm: Provide helper for finishing mkwrite faults Jan Kara
2016-11-15 22:52 ` Kirill A. Shutemov
2016-11-16 13:39 ` Jan Kara
2016-11-04 4:25 ` [PATCH 17/21] mm: Change return values of finish_mkwrite_fault() Jan Kara
2016-11-15 22:57 ` Kirill A. Shutemov
2016-11-04 4:25 ` [PATCH 18/21] mm: Export follow_pte() Jan Kara
2016-11-04 4:25 ` [PATCH 19/21] dax: Make cache flushing protected by entry lock Jan Kara
2016-11-04 4:25 ` [PATCH 20/21] dax: Protect PTE modification on WP fault by radix tree " Jan Kara
2016-11-04 4:25 ` [PATCH 21/21] dax: Clear dirty entry tags on cache flush Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2016-11-01 22:36 [PATCH 0/21 v4] dax: Clear dirty bits after flushing caches Jan Kara
2016-11-01 22:36 ` [PATCH 04/21] mm: Use passed vm_fault structure in __do_fault() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478233517-3571-5-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox