From: Neil Brown <neilb@cse.unsw.edu.au>
To: Tigran Aivazian <tigran@veritas.com>
Cc: linux-mm@kvack.org
Subject: Re: 2.4.0-test7-pre4 oops in generic_make_request()
Date: Thu, 17 Aug 2000 08:58:21 +1000 (EST) [thread overview]
Message-ID: <14747.7309.941683.168466@notabene.cse.unsw.edu.au> (raw)
In-Reply-To: message from Tigran Aivazian on Wednesday August 16
On Wednesday August 16, tigran@veritas.com wrote:
> Hi guys,
>
> linux-kernel is dead so I am posting this oops here. This is
> 2.4.0-test7-pre4 slightly patched by
>
> http://www.moses.uklinux.net/patches/linux-vxfs-2.4.0-test7-pre4.patch
>
> (the patch is irrelevant to the oops but I list for completeness)
>
> I was mkfs'ing a new filesystem on a 61G disk partition. Oops is
> interesting (the fact that mkfs is actually mkfs.vxfs is totally
> irrelevant - think of it as "some app" which writes some stuff to
> /dev/hdd1).
>
> Regards,
> Tigran
This was my fault. Patch has already been sent to Linus and
linux-kernel, but pre5 seems to be a while coming.
But it looks like you are doing IO on a raw (drivers/char/raw.c)
device, rather than /dev/hdd1. Is that right?
NeilBrown
--- fs/buffer.c 2000/08/14 23:05:44 1.2
+++ fs/buffer.c 2000/08/14 23:10:30
@@ -1837,6 +1837,7 @@
int pageind;
int bhind;
int offset;
+ int sectors = size>>9;
unsigned long blocknr;
struct kiobuf * iobuf = NULL;
struct page * map;
@@ -1888,9 +1889,10 @@
tmp->b_this_page = tmp;
init_buffer(tmp, end_buffer_io_kiobuf, iobuf);
- tmp->b_dev = dev;
+ tmp->b_rdev = tmp->b_dev = dev;
tmp->b_blocknr = blocknr;
- tmp->b_state = 1 << BH_Mapped;
+ tmp->b_rsector = blocknr*sectors;
+ tmp->b_state = (1 << BH_Mapped) | (1 << BH_Lock) | (1 << BH_Req);
if (rw == WRITE) {
set_bit(BH_Uptodate, &tmp->b_state);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-08-16 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-08-16 21:04 Tigran Aivazian
2000-08-16 22:58 ` Neil Brown [this message]
2000-08-17 8:12 ` Tigran Aivazian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14747.7309.941683.168466@notabene.cse.unsw.edu.au \
--to=neilb@cse.unsw.edu.au \
--cc=linux-mm@kvack.org \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox