From: Andrea Arcangeli <aarcange@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 0/4] mm: vma_merge/vma_adjust minor updates against -mm
Date: Wed, 21 Sep 2016 23:15:18 +0200 [thread overview]
Message-ID: <1474492522-2261-1-git-send-email-aarcange@redhat.com> (raw)
Hello,
Here 4 more minor patches that are incremental against -mm.
In short:
1/4) updates vm_page_prot atomically as it's updated outside the
rmap_locks. It's always better to use READ_ONCE/WRITE_ONCE if the
access is concurrent from multiple CPUs, even if there wouldn't
be risk of reading intermediate values... like in this case there
is too.
Not critical, theoretical issue only so far, it might be possible
that gcc emits right asm code already, but this is safer and
forces gcc to emit the right asm code.
2/4) comment correction
Not critical, noop change.
3/4) adapts CONFIG_DEBUG_VM_RB=y to cope with the case of
next->vm_start reduced. Earlier that could never happen and
vma->vm_end was always increased instead. validate_mm() is always
called before returning from vma_adjust() and the argumented
rbtree is always consistent while exercising a flood of case8.
Not critical if CONFIG_DEBUG_VM_RB=n as there's no functional
change in such case. Critical if you set CONFIG_DEBUG_VM_RB=y, in
which case without the patch false positives are emitted.
4/4) cleanup a line that is superfluous and in turns it can confuse
the reader if the reader assumes it's not superfluous.
Not critical, noop change.
Andrea Arcangeli (4):
mm: vm_page_prot: update with WRITE_ONCE/READ_ONCE
mm: vma_adjust: minor comment correction
mm: vma_merge: correct false positive from
__vma_unlink->validate_mm_rb
mm: vma_adjust: remove superfluous confusing update in remove_next ==
1 case
mm/huge_memory.c | 2 +-
mm/migrate.c | 2 +-
mm/mmap.c | 94 +++++++++++++++++++++++++++++++++++++++++---------------
3 files changed, 72 insertions(+), 26 deletions(-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-09-21 21:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 21:15 Andrea Arcangeli [this message]
2016-09-21 21:15 ` [PATCH 1/4] mm: vm_page_prot: update with WRITE_ONCE/READ_ONCE Andrea Arcangeli
2016-09-22 7:17 ` Hillf Danton
2016-09-22 19:15 ` Andrea Arcangeli
2016-09-23 19:51 ` Andrea Arcangeli
2016-09-21 21:15 ` [PATCH 2/4] mm: vma_adjust: minor comment correction Andrea Arcangeli
2016-09-21 21:15 ` [PATCH 3/4] mm: vma_merge: correct false positive from __vma_unlink->validate_mm_rb Andrea Arcangeli
2016-09-21 21:15 ` [PATCH 4/4] mm: vma_adjust: remove superfluous confusing update in remove_next == 1 case Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474492522-2261-1-git-send-email-aarcange@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox