From: Li Zhong <zhong@linux.vnet.ibm.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm <linux-mm@kvack.org>,
John Allen <jallen@linux.vnet.ibm.com>,
qiuxishi@huawei.com, iamjoonsoo.kim@lge.com,
n-horiguchi@ah.jp.nec.com, rientjes@google.com,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: [PATCH] mm, page_alloc: warn about empty nodemask
Date: Wed, 07 Sep 2016 08:41:26 +0800 [thread overview]
Message-ID: <1473208886.12692.2.camel@TP420> (raw)
In-Reply-To: <3a661375-95d9-d1ff-c799-a0c5d9cec5e3@suse.cz>
Warn about allocating with an empty nodemask, it would be easier to
understand than oom messages. The check is added in the slow path.
Suggested-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
---
mm/page_alloc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a2214c6..d624ff3 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3448,6 +3448,12 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
if (page)
goto got_pg;
+ if (ac->nodemask && nodes_empty(*ac->nodemask)) {
+ pr_warn("nodemask is empty\n");
+ gfp_mask &= ~__GFP_NOWARN;
+ goto nopage;
+ }
+
/*
* For costly allocations, try direct compaction first, as it's likely
* that we have enough base pages and don't need to reclaim. Don't try
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-07 7:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 2:59 [PATCH] mem-hotplug: Don't clear the only node in new_node_page() Li Zhong
2016-09-05 14:18 ` Vlastimil Babka
2016-09-06 8:13 ` Li Zhong
2016-09-06 14:12 ` Vlastimil Babka
2016-09-07 0:41 ` Li Zhong [this message]
2016-09-08 23:26 ` [PATCH] mm, page_alloc: warn about empty nodemask Andrew Morton
2016-09-09 4:03 ` Li Zhong
2016-09-20 8:27 ` Vlastimil Babka
2016-09-12 9:18 ` [PATCH] mem-hotplug: Don't clear the only node in new_node_page() Michal Hocko
2016-09-20 8:31 ` Vlastimil Babka
2016-09-20 21:53 ` David Rientjes
2016-09-21 2:11 ` Li Zhong
2016-09-21 8:38 ` [PATCH] mem-hotplug: Use nodes that contain memory as mask " Li Zhong
2016-09-21 9:34 ` Vlastimil Babka
2016-09-21 18:14 ` Michal Hocko
2016-09-21 18:08 ` [PATCH] mem-hotplug: Don't clear the only node " Michal Hocko
2016-09-06 13:16 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473208886.12692.2.camel@TP420 \
--to=zhong@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jallen@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox