From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Jann Horn <jann@thejh.net>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] fs, proc: optimize smaps output formatting
Date: Fri, 19 Aug 2016 13:18:44 -0700 [thread overview]
Message-ID: <1471637924.3893.48.camel@perches.com> (raw)
In-Reply-To: <1471628595.3893.23.camel@perches.com>
On Fri, 2016-08-19 at 10:43 -0700, Joe Perches wrote:
> And this would definitely be faster if seq_has_overflowed() was
> used somewhere in the iteration loop.
Adding a seq_has_overflowed() test seems unnecessary as the
fs/seq_file.c traverse() static function already does a
seq_has_overflowed().
And I get:
$ t_mm (your allocate all vma program modified to show count)
count: 65514 pid:2051
$ wc -c /proc/2051/smaps
39515615 /proc/2051/smaps
smap vma output is a little more than 600 bytes per vma.
I'll look around to see how best go use single_open_size
assuming 768 bytes/vma rounded up to the next PAGE_SIZE.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-19 20:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 11:31 [PATCH] proc, smaps: reduce printing overhead Michal Hocko
2016-08-18 13:26 ` Joe Perches
2016-08-18 14:26 ` Michal Hocko
2016-08-18 14:41 ` Joe Perches
2016-08-18 14:41 ` Michal Hocko
2016-08-18 14:46 ` Joe Perches
2016-08-18 14:58 ` Michal Hocko
2016-08-18 15:23 ` Joe Perches
2016-08-18 16:42 ` Michal Hocko
2016-08-19 10:12 ` [PATCH 0/2] fs, proc: optimize smaps output formatting Michal Hocko
2016-08-19 10:12 ` [PATCH 1/2] proc, meminfo: abstract show_val_kb Michal Hocko
2016-08-26 2:54 ` [lkp] [proc, meminfo] dd3b422c11: stderr.Signal#(FPE)caught_by_ps(procps-ng_version#) kernel test robot
2016-08-19 10:13 ` [PATCH 2/2] proc, smaps: reduce printing overhead Michal Hocko
2016-08-19 17:43 ` [PATCH 0/2] fs, proc: optimize smaps output formatting Joe Perches
2016-08-19 20:18 ` Joe Perches [this message]
2016-08-20 7:29 ` Michal Hocko
2016-08-20 7:55 ` Joe Perches
2016-08-20 8:00 ` [PATCH 0/2] seq: Speed up /proc/<pid>/smaps Joe Perches
2016-08-20 8:00 ` [PATCH 1/2] seq_file: Add __seq_open_private_bufsize for seq file_operation sizes Joe Perches
2016-08-20 8:00 ` [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Joe Perches
2016-08-22 7:24 ` Michal Hocko
2016-08-22 8:00 ` Joe Perches
2016-08-22 8:30 ` Joe Perches
2016-08-22 12:09 ` Michal Hocko
2016-08-23 15:14 ` [PATCH] proc, smaps: reduce printing overhead Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471637924.3893.48.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=jann@thejh.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox