From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Jann Horn <jann@thejh.net>
Subject: Re: [PATCH] proc, smaps: reduce printing overhead
Date: Thu, 18 Aug 2016 07:46:03 -0700 [thread overview]
Message-ID: <1471531563.4319.41.camel@perches.com> (raw)
In-Reply-To: <20160818144149.GO30162@dhcp22.suse.cz>
On Thu, 2016-08-18 at 16:41 +0200, Michal Hocko wrote:
> On Thu 18-08-16 16:26:16, Michal Hocko wrote:
> > b) doesn't it try to be overly clever when doing that in the caller
> > doesn't cost all that much? Sure you can save few bytes in the spaces
> > but then I would just argue to use \t rather than fixed string length.
> ohh, I misread the code. It tries to emulate the width formater. But is
> this really necessary? Do we know about any tools doing a fixed string
> parsing?
I don't, but it's proc and all the output formatting
shouldn't be changed.
Appended to is generally OK, but whitespace changed is
not good.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-18 14:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 11:31 Michal Hocko
2016-08-18 13:26 ` Joe Perches
2016-08-18 14:26 ` Michal Hocko
2016-08-18 14:41 ` Joe Perches
2016-08-18 14:41 ` Michal Hocko
2016-08-18 14:46 ` Joe Perches [this message]
2016-08-18 14:58 ` Michal Hocko
2016-08-18 15:23 ` Joe Perches
2016-08-18 16:42 ` Michal Hocko
2016-08-19 10:12 ` [PATCH 0/2] fs, proc: optimize smaps output formatting Michal Hocko
2016-08-19 10:12 ` [PATCH 1/2] proc, meminfo: abstract show_val_kb Michal Hocko
2016-08-26 2:54 ` [lkp] [proc, meminfo] dd3b422c11: stderr.Signal#(FPE)caught_by_ps(procps-ng_version#) kernel test robot
2016-08-19 10:13 ` [PATCH 2/2] proc, smaps: reduce printing overhead Michal Hocko
2016-08-19 17:43 ` [PATCH 0/2] fs, proc: optimize smaps output formatting Joe Perches
2016-08-19 20:18 ` Joe Perches
2016-08-20 7:29 ` Michal Hocko
2016-08-20 7:55 ` Joe Perches
2016-08-20 8:00 ` [PATCH 0/2] seq: Speed up /proc/<pid>/smaps Joe Perches
2016-08-20 8:00 ` [PATCH 1/2] seq_file: Add __seq_open_private_bufsize for seq file_operation sizes Joe Perches
2016-08-20 8:00 ` [PATCH 2/2] proc: task_mmu: Reduce output processing cpu time Joe Perches
2016-08-22 7:24 ` Michal Hocko
2016-08-22 8:00 ` Joe Perches
2016-08-22 8:30 ` Joe Perches
2016-08-22 12:09 ` Michal Hocko
2016-08-23 15:14 ` [PATCH] proc, smaps: reduce printing overhead Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471531563.4319.41.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=jann@thejh.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox