From: Rik van Riel <riel@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86/mm: disable preemption during CR3 read+write
Date: Fri, 05 Aug 2016 10:38:33 -0400 [thread overview]
Message-ID: <1470407913.13905.66.camel@redhat.com> (raw)
In-Reply-To: <1470404259-26290-1-git-send-email-bigeasy@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Fri, 2016-08-05 at 15:37 +0200, Sebastian Andrzej Siewior wrote:
>
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -135,7 +135,14 @@ static inline void
> cr4_set_bits_and_update_boot(unsigned long mask)
>
> static inline void __native_flush_tlb(void)
> {
> + /*
> + * if current->mm == NULL then we borrow a mm which may
> change during a
> + * task switch and therefore we must not be preempted while
> we write CR3
> + * back.
> + */
> + preempt_disable();
> native_write_cr3(native_read_cr3());
> + preempt_enable();
> }
That is one subtle race!
Acked-by: Rik van Riel <riel@redhat.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-05 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 13:37 Sebastian Andrzej Siewior
2016-08-05 13:53 ` Peter Zijlstra
2016-08-05 14:38 ` Rik van Riel [this message]
2016-08-05 15:42 ` Andy Lutomirski
2016-08-05 15:52 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470407913.13905.66.camel@redhat.com \
--to=riel@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bigeasy@linutronix.de \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox