From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFABC0219B for ; Tue, 11 Feb 2025 14:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBFA2280002; Tue, 11 Feb 2025 09:52:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6EB9280001; Tue, 11 Feb 2025 09:52:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5D79280002; Tue, 11 Feb 2025 09:52:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B8B39280001 for ; Tue, 11 Feb 2025 09:52:18 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D301312038E for ; Tue, 11 Feb 2025 14:51:44 +0000 (UTC) X-FDA: 83107952928.08.1EF4F0C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 3A7B940003 for ; Tue, 11 Feb 2025 14:51:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Cp5o/yL3"; spf=pass (imf27.hostedemail.com: domain of luizcap@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739285502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+0lYtbdnnypFcNiRcv6+Uu06HRU3vMAla5QbvyE8U5Y=; b=nLtIwXejbYmSYwywrsXauROnXhKk6zjGJxf8ls4CD9NYtGRlOYzSG7R/5z0sUboPTC3ugB zTOFfBtJ+bcq6A0OoYVZOq5xlyTwdeHMwodsODxr6Qw1/cLi1gSNL1uSUicHIuVkpbh/lD xZYh2Gp5rhLaJGoNS+T9DBsMbOnQ1J4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Cp5o/yL3"; spf=pass (imf27.hostedemail.com: domain of luizcap@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739285502; a=rsa-sha256; cv=none; b=o6S/OcahH5AhZ8r+o4EFGGPMF+m2HQ9jxDEn0tGBuEl4zVL2xZIuDfNxAxhlqQoQsjTwn2 H+v5r7PRAWa5RU3/1f/eMQ3K8aL/wOAmC3G92FXW9KwZvTdv4fYPMb2t2nIgfiEgo/8YVM 7mUbTyTpBPIQ+4sYGxWokz2ZykrAKdQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739285501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+0lYtbdnnypFcNiRcv6+Uu06HRU3vMAla5QbvyE8U5Y=; b=Cp5o/yL32qVDtMRRHzqOv2BoTAZODd4cHP39iMlAfYVjUr4a0lw7Rdv4DYyChf4m1BJd1M sj+R3IjEhR2hS1lMQI35+X5uxi8OGEuwKbnFERnc8Rm16/GHES0YGu6/5E0yLOJudPSkte MMjaZkDGEBQ3yCXuvuacz6CzO1ErxiI= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-0fimuUC5Nq-wshVdXYC3PQ-1; Tue, 11 Feb 2025 09:51:40 -0500 X-MC-Unique: 0fimuUC5Nq-wshVdXYC3PQ-1 X-Mimecast-MFC-AGG-ID: 0fimuUC5Nq-wshVdXYC3PQ Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-467b19b55d6so57206051cf.2 for ; Tue, 11 Feb 2025 06:51:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739285500; x=1739890300; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+0lYtbdnnypFcNiRcv6+Uu06HRU3vMAla5QbvyE8U5Y=; b=fs2mwiWG7CSZk6gy5WobaAm7f5WFKLwJO9bFNgey/jOLHsA90kyrwVvmwGqqNwsahi bznbYDaC4CenuTawGGtgW4kzNGpm7akfOifNPC4fzpnIwAkiCqwG9kdOIIGV9JKqd5Wu p5OUDINrEYLoS9lkPre4Nrx5Q//0EnSQ0tzT9unPC28qM99U5pmp0yW6WAe2Dt8kZaqz nKsYdrte+UKLH8vNFzU2RI7gTM29PgF70RBB1dKQi6cC5Qht+qH1LQmbed/ktso3m5Am PXz4+HXDSXlvg7whCaMmpE7ULyWaeJWbM1G9ZnrzNGJsbyoU3QNRE9uhXPJYZ9MBaXxQ 0Ujw== X-Forwarded-Encrypted: i=1; AJvYcCUdrArrOqXIO87/0OnrrE4ovLfVqcndqQTsudNogGOR/VmWPafM+fgSmgg83eAd23JDzdYPZuzR+Q==@kvack.org X-Gm-Message-State: AOJu0YzMJ9i63e16zDfUu8R/3FGdntXodxh1E/SbJYEfuq4lGY6SkytT kRNiANZxR9wNzSBX0928twNBIV8pdnLheED38hmJ19JIgcgwlEqrT5WqbuOyRlvTutc1IzCmYVq oRu+9/hwaLg3SIcVqa6f4BSPWCj0rt+HMCtK45HfUtgcZaZVK X-Gm-Gg: ASbGncsJ2LWBeN8C0SWxgXZwR5TBHlD2vruL+HpF925DK0dDPfRryJ2sSYViMV/PH1S WLbgUT1/tW0Y7ntjtkk9lFZi8eXrd18GkGsy1o5J8FCpDJewZO76Pv13UXf5f6QiUrd1tqHCcK+ axsf4lyM68AOBv9jkQrOPbOKAMO2zdh0goMTemKcMojD9XOq8VN8Dg0CLuqlMePifrWPJ4FqgZc E/5/ilOOB4vLcFCg60E4HGwpMn9NKURiK+9/D4o2f3qxEtUptn3S1CO0lEqzoD3856/3a1Erj+3 DwfV X-Received: by 2002:a05:622a:1a12:b0:471:8cab:6eec with SMTP id d75a77b69052e-4718cab7063mr132964981cf.23.1739285499838; Tue, 11 Feb 2025 06:51:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqpMXJkFVeSdMyW4O8CVvFJXxtdKttGMxO3hSI/z5qgxQYhMp5NMbZw0e9GouNCdFj+JVHTg== X-Received: by 2002:a05:622a:1a12:b0:471:8cab:6eec with SMTP id d75a77b69052e-4718cab7063mr132964691cf.23.1739285499525; Tue, 11 Feb 2025 06:51:39 -0800 (PST) Received: from [192.168.2.110] ([70.52.22.87]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47195c6a2dbsm24611101cf.48.2025.02.11.06.51.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 06:51:39 -0800 (PST) Message-ID: <146d87a2-ad3b-4070-862f-c92c91df27b2@redhat.com> Date: Tue, 11 Feb 2025 09:51:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: hugetlb: avoid fallback for specific node allocation of 1G pages To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, yaozhenguo1@gmail.com, muchun.song@linux.dev, linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, rppt@kernel.org, fvdl@google.com References: <20250211034856.629371-1-luizcap@redhat.com> From: Luiz Capitulino In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j6eAzNqw79Y9XQetlfvpCrS1WwkIncPBHDH6nIjOLHw_1739285500 X-Mimecast-Originator: redhat.com Content-Language: en-US, en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3A7B940003 X-Stat-Signature: e9o8j9fhi5wd1re9wq4ohxfecjfznak8 X-Rspam-User: X-HE-Tag: 1739285502-450896 X-HE-Meta: U2FsdGVkX19zVqqK+MDJPncWPphrzog7RvO2cRpVFMDR5B2jC594dzKJw3Sh1J7tkp+awY2spWtlZpHQK2CXFsMoX3crt6RCv/muW3/G1A8BZlzDx+PvFXBmKUOu/PeRd1Ry956NbDsIyHL4qdwtQw6IzsXkUNxT08XWp6o5Lay65KIHr2MApQonyL8YyURQTMtaJTMrApgbez54YNAQf/QqQ0+rAuicdRd2qRUs/xM4cO0ZwuRtUVca7n6zhBn4E2iSICg0p4iBVtBh55Oy05vK9JBMkteZsPae/bwOp9hcT48DQsdYlum4TSanbfVSmyqR1eljcHnuM3M425GyQPNGbAhe5oAmGUp+ttHE6WaRlR5+1Szaa8b/m2xS6pFKm5M1ejUTWUPmZjze7XEiCC41xZT3btCeBCKrvyOVjUTXw2mAZzM01cqsQ2giakWjK5HnxNa0dFM5F1n/FpxXqWE//HEMN+td/dJRQMiC7/Lq/SV4kRLEsoyWKJWIuUqruPsSFQ/E68r66JbnfGyROkTYUMoIR8DTsXoqDtd8FyaF7g+O8AXFqCVgNd9tlcTA4iKoWay2g7CkNnWlEUC2DZovzN9zOTkkoR7OLh7kw1dYDxg4vT6dSu3T6r+ZlHAWPSegVGMiwT2AEmNQnUshpGT1xcELzhpt4o6GZ0aGxJGNyo5B30+7SUrvSsmOXGKcWXU6cEpaR35IHg4l/S5FoBtQz/DMpP/KaClfrsecUDa/c6DxQC7W6SBccXGXS6XcX1JNOFrF1cSCcZVq/ba6DAb7J5nPs2tLuA7LN864jSV+hKL3bOhq9li0k6gANouWj1SwpJeEk7Q17f8ZmJGBRuWi4s91kKIs0etZiPL35KgJuT3wPOp393+n5XZiwxECPh3SliQ8FBP4AQ1IxXBc2G0f7F9y6DZv7vpdExzVEhdLv/jTv7kxFpfKH17h7Q3qD/R17ukc0JNrv5sqCaT BDOM7MMP eX13KudyCyesrsiVaR0NHT/WFT42NYObOgliZQh2JvIvp3TRYyChWwUhiIBT5YASwLgeJsArrOzq8b+/IKAXJ69P+8DAQ+eD3xhbTW12cE9H3vtRYrfqNsuWn8w2GLjLOFukgh0DsfGclOvcV0TAuXpcQdnf6jvR2E63mKdyswQQvdLg1V+Fo7u+0EiHDHKSRHG2S9XDNoJKsJq9q8iOSwDpHnV0XGLXPZfpWSDvHDPMHYPqahnuNLxPsaS5vN4FLZiOCi2e2foOAkTqzMI62F30xybPVp3OSynlT3M9Xr7bY/TAInzGUiRx2PiatH8KXQm0LyQw+d1s6azB134f5yPdDjqY0+/QGv9H+/5DtnpOqirM5zI1rqs2aIY6LFefXRi0BQQRFrGvK7g4e5MCqWUZYlOtbb9CAziTPvJYxaeruSI4aqOf+vnFSLhEFYkVwI5Uj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-02-11 04:06, Oscar Salvador wrote: > On Mon, Feb 10, 2025 at 10:48:56PM -0500, Luiz Capitulino wrote: >> When using the HugeTLB kernel command-line to allocate 1G pages from >> a specific node, such as: >> >> default_hugepagesz=1G hugepages=1:1 >> >> If node 1 happens to not have enough memory for the requested number of >> 1G pages, the allocation falls back to other nodes. A quick way to >> reproduce this is by creating a KVM guest with a memory-less node and >> trying to allocate 1 1G page from it. Instead of failing, the allocation >> will fallback to other nodes. >> >> This defeats the purpose of node specific allocation. Also, specific >> node allocation for 2M pages don't have this behavior: the allocation >> will just fail for the pages it can't satisfy. >> >> This issue happens because HugeTLB calls memblock_alloc_try_nid_raw() >> for 1G boot-time allocation as this function falls back to other nodes >> if the allocation can't be satisfied. Use memblock_alloc_exact_nid_raw() >> instead, which ensures that the allocation will only be satisfied from >> the specified node. >> >> Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") >> >> Signed-off-by: Luiz Capitulino > > Acked-by: Oscar Salvador > > This was discussed yesterday in [1], ccing Frank for awareness. > > [1] https://patchwork.kernel.org/project/linux-mm/patch/20250206185109.1210657-6-fvdl@google.com/ Interesting, thanks for the reference. I stumbled over this issue back in December when debugging a HugeTLB issue at Red Hat (David knows it ;) ) and had this patch pending for more than a week now...