From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0923BC433ED for ; Thu, 6 May 2021 19:14:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7884D6113E for ; Thu, 6 May 2021 19:14:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7884D6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F068A6B006C; Thu, 6 May 2021 15:14:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB4976B006E; Thu, 6 May 2021 15:14:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2DCE6B0070; Thu, 6 May 2021 15:14:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id B95546B006C for ; Thu, 6 May 2021 15:14:48 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 744407817 for ; Thu, 6 May 2021 19:14:48 +0000 (UTC) X-FDA: 78111758256.35.3C9BEE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 3F79CE0011E2 for ; Thu, 6 May 2021 19:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620328487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LxJCtrJc+hn1vhOwMRBMiLEsVjLTk4AmYnUbr3bQtaE=; b=PLRvuvKSFI1DBA41oyQZfmh5KBtNY7jp9bfmvhGxSvQHtx0HkfmIdlhEHoaBBb18LF3AOM 6lYi62N3cIRS2MC9cNkAYTtSyTqaEZyJ7/MvGXFS7pLcnBjmicQBouSbd0WuWOO8CFt0Dm U/iwtdnTNMQIyW096DYgRPjOV5+xK6M= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-Vn8WxYc-PV6OE2kRNDp8bQ-1; Thu, 06 May 2021 15:14:45 -0400 X-MC-Unique: Vn8WxYc-PV6OE2kRNDp8bQ-1 Received: by mail-ej1-f69.google.com with SMTP id ne22-20020a1709077b96b02903803a047edeso2111681ejc.3 for ; Thu, 06 May 2021 12:14:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LxJCtrJc+hn1vhOwMRBMiLEsVjLTk4AmYnUbr3bQtaE=; b=hCq5/nbdN8CIE/OaD1TYQqaVwTCkUH5eiNj6PR/buT22Y3+E4OOB7CfLCO06KyPG86 Rr/65ugcp7W6rZCKHmjjdanxVjDTUQiH7SznaOqtQUwtWHLOVVqhpsrn3rgP+OPSYGWK hbFaR16o+cWxq21iDTh4Y3WZCFXy3jrs0r+qP8ZBUO8KgEhVvIMleHLkYfrLiXhJGCsT x1iuETYHuA8d+K0gdug+Vxfb0kUsNYukAd/SBoYsaRCDNocHu82SVhHJRSXw3wDmeffF ymSs/3htQeS8/XhLadPEY52iTIfYAfYhIFISQgmpb50jKTnkeVqOk8O1521UB6x2aRbD Zf7A== X-Gm-Message-State: AOAM5302wwV5Egi/EiOaB1fZZxJ/WF+A5d66nI7UsOVekumjvqdAbC06 HqjkauxJEV7HeyAXpA4LXNwrAC7Yo8UshPAundv77evNiHqq3aWktm5XjWOIRd9WEwCP8P0K2MK TpJgvw5CFfb8wCbwhggQJP9pBC8kwizODR+IqKqDCurRVIqx9e4d30dpDokQ= X-Received: by 2002:aa7:d843:: with SMTP id f3mr7130715eds.270.1620328484618; Thu, 06 May 2021 12:14:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMDfCDANHagwyvMGFrV1L6sL7t6UDHQRxiwpmWElp0FfWEi44uao+v+GyT+Pf6/v6QHjNNZw== X-Received: by 2002:aa7:d843:: with SMTP id f3mr7130678eds.270.1620328484331; Thu, 06 May 2021 12:14:44 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64ae.dip0.t-ipconnect.de. [91.12.100.174]) by smtp.gmail.com with ESMTPSA id x7sm1924071ejc.116.2021.05.06.12.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 12:14:44 -0700 (PDT) To: Zi Yan Cc: Oscar Salvador , Michael Ellerman , Benjamin Herrenschmidt , Thomas Gleixner , x86@kernel.org, Andy Lutomirski , "Rafael J . Wysocki" , Andrew Morton , Mike Rapoport , Anshuman Khandual , Michal Hocko , Dan Williams , Wei Yang , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org References: <20210506152623.178731-1-zi.yan@sent.com> <20210506152623.178731-2-zi.yan@sent.com> <06dfaf69-1173-462c-b85f-8715cb8d108c@redhat.com> <71EE13C0-9CF7-4F1F-9C17-64500A854BD8@nvidia.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH 1/7] mm: sparse: set/clear subsection bitmap when pages are onlined/offlined. Message-ID: <146a1ec6-38b3-9724-b346-9bb6e7e24c72@redhat.com> Date: Thu, 6 May 2021 21:14:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <71EE13C0-9CF7-4F1F-9C17-64500A854BD8@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PLRvuvKS; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: k37knmru77ux883mz8ncsszifhgkicwh X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3F79CE0011E2 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620328483-663624 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> But glimpsing at patch #2, I'd rather stop right away digging deeper i= nto this series :) >=20 > What is the issue of patch 2, which makes pageblock_order a variable al= l the time? BTW, patch 2 fixes a bug by exporting pageblock_order, since = when HUGETLB_PAGE_SIZE_VARIABLE is set, virtio-mem will not see pageblock= _order as a variable, which could happen for PPC_BOOK2S_64 with virtio-me= n enabled, right? Or is this an invalid combination? virtio_mem is x86_64 only. aarch64 and s390x prototypes are available. If I understood "Make pageblock_order a variable and set it to the max of HUGETLB_PAGE_ORDER, MAX_ORDER - 1" correctly,=20 you're setting the pageblock_order on x86_64 to 4M. That mean's you're=20 no longer grouping for THP but MAX_ORDER - 1, which is not what we want.=20 We want to optimize for THP. Also, that would affect virtio-balloon with free page reporting (report=20 only 4 MiB chunks not 2 MiB chunks). >=20 >> >> I think what would really help is drafting a design of how it all coul= d look like and then first discussing the high-level design, investigatin= g how it could play along with all existing users, existing workloads, an= d existing use cases. Proposing such changes without a clear picture in m= ind and a high-level overview might give you some unpleasant reactions fr= om some of the developers around here ;) >=20 > Please see my other email for a high-level design. Also I sent the patc= hset as a RFC to gather information on users, workloads, use cases I did = not know about and I learnt a lot from your replies. :) Feedback is alway= s welcome, but I am not sure why it needs to make people unpleasant. ;) Rather the replies might be unpleasant ;) --=20 Thanks, David / dhildenb