From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810A5E7719A for ; Sat, 11 Jan 2025 10:03:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12CF16B0088; Sat, 11 Jan 2025 05:03:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08EEF6B0089; Sat, 11 Jan 2025 05:03:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFCAE6B008C; Sat, 11 Jan 2025 05:03:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BDBF16B0088 for ; Sat, 11 Jan 2025 05:03:27 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 698F71611BC for ; Sat, 11 Jan 2025 10:03:27 +0000 (UTC) X-FDA: 82994733654.19.CFBEE3E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id D878D40004 for ; Sat, 11 Jan 2025 10:03:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FnVkqo4L; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736589805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bdLPllsNKcroQKaJckZ27aAerUfL4hT2TBF+GYVpZwo=; b=ybOky4r146rLeNo9PoC2AJ9fT02OuZmf1eObLN6sdL2/N1FG1sm12YpcE1mn+r+5nDpbja bvS2i5kp9hWS/CdYywMOtEufi7C9YgK5YK1xdTcFTSGebNzjpZHUKoLbuXcpArc/Z/6ycv rUk0bVK/JsbwzGesJLmxV3roMZCrwR0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736589805; a=rsa-sha256; cv=none; b=K/Fa2v5NjeIfl6ulPeNU1LUrKK8e6JNsQGZSquRJvvNp5FkvFoC2ShDtnckEjvKZslEEWa 1WBzKJPvBl6cHpGMugxvt9rETQrl3sLLOvkWfFs/4VBfD/9geQOA2AqqeuihNqs/r/Cekb +d7UKcDmAOnJlhCURcDYGWUnQybBHMw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FnVkqo4L; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736589804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bdLPllsNKcroQKaJckZ27aAerUfL4hT2TBF+GYVpZwo=; b=FnVkqo4L0sYPTUcGiltiS6rOU/X0RqoN4u8LHZfXHcIQtm3xJcQPbQOULjrFBIco2+ZbyR ra8RxtMD7saVtJUpdpYrOxRnsajAK+VBHHy1q8bZGhMAOerXwPLmQxxMPZ6St5G58ejuib gw+ualiEV+gMZgxR6YgzPjKDUmjSBEQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-jSbw-4u2MreoY-JLiFE4nA-1; Sat, 11 Jan 2025 05:03:22 -0500 X-MC-Unique: jSbw-4u2MreoY-JLiFE4nA-1 X-Mimecast-MFC-AGG-ID: jSbw-4u2MreoY-JLiFE4nA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361a8fc3bdso13968865e9.2 for ; Sat, 11 Jan 2025 02:03:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736589801; x=1737194601; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bdLPllsNKcroQKaJckZ27aAerUfL4hT2TBF+GYVpZwo=; b=do3UGzVoYhbluQ8/HowAPgBRRiTk+2CCHtV92riYNcUUWDmaWteyeBdajxXyQpPyug UjBaH6VS7neWiJyLd8CiEQUwOpAhriDIrtEQqfvt6mKj0UON830cmbIcMSDO/6UdSKpF A0T5Gtui/HCxfYpM0MX8t2ITm0a7bSc3VYju8aV3rHQxTITUe/mlIKwO2hd2pyIi2QkE Z7E0SN48eV4lC/7vKnJ0wYd0tBinmVDvOeZeUBjUdQcapXuhH3qd3XV0Vo22s88FH3bF 3JNNIq867j/sPLuBC+W+xyCIza+ZEIzZ1pOejncbMJNG1EsGAI0VpKAX0r7LGOlAuBkM ZUlw== X-Forwarded-Encrypted: i=1; AJvYcCU6ZK2bWKdqoLQa2g60cA9gvzd6Qye58/eAkYL1lSYdw7VoK6SBIek0Pz/SFtXqedljT8nlKqII7w==@kvack.org X-Gm-Message-State: AOJu0YyF4drv1VfQndP1FRUH2sAwUpHm03w99KBH+Q44AGq9rpLGsoUT JYIawgOKLezU4UmM54R8p0pzwC72DCT4K2ta92qcHhg4/L6ZbSsQRCKmotHxjjVFnPVIqu/pjSI lvzb/S8pqtuRTahJStDKWEEHPAgCaV7w+QYPEU4V0pUFdYQvZ X-Gm-Gg: ASbGncssY3wyP5MKj5Q7nCHBgWLL+8QCmJVIZjY/oeDaG9L0U5MkGY/KOr24Fzh0lrF 7DFbB1KruGti/E/PFwK5BXUJsDQgmaBxFi1Kk1OwcFypqK2ZgcjRfO/gpkmsVI1rWqvdHX3ZS9v Kcjhrby1QLFmbsaDOfXnb5w2YgQMatQs7DBbqGqHXoJNz4vcY13mB1eJ352deOJ+lIOtd8ZkTSA rHOdXlhyiyHOfsFaM+D8AiP+P19UJFvrLrK7xGnXjEsJEAqwlAMS/Jn67R90jjmj77cDr1SaADh ozH2fNc96OIHnU5SJpxpbKsqEXFaDds7K0+XWkPzmuasO0W1dSim+OvprH6lC31seyjmh5ImSEh Kw3nhwfBs X-Received: by 2002:a05:600c:3b2a:b0:434:f623:9ff3 with SMTP id 5b1f17b1804b1-436e26a8c3cmr134859355e9.15.1736589801112; Sat, 11 Jan 2025 02:03:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/lxRmg7UrpgVWl1Z4SNK14ZltIiePfJb8Aej5HMhpyE13Oi8DQ5I4eqyY7pGjL1bQcKJ+xg== X-Received: by 2002:a05:600c:3b2a:b0:434:f623:9ff3 with SMTP id 5b1f17b1804b1-436e26a8c3cmr134859005e9.15.1736589800600; Sat, 11 Jan 2025 02:03:20 -0800 (PST) Received: from ?IPV6:2003:cb:c714:a300:c534:35c3:a7d9:f55c? (p200300cbc714a300c53435c3a7d9f55c.dip0.t-ipconnect.de. [2003:cb:c714:a300:c534:35c3:a7d9:f55c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9d8fc5csm78761495e9.2.2025.01.11.02.03.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jan 2025 02:03:19 -0800 (PST) Message-ID: <1468cf2b-f4ff-4e32-9491-ad91e48d041b@redhat.com> Date: Sat, 11 Jan 2025 11:03:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING in __folio_rmap_sanity_checks (2) To: Hillf Danton Cc: syzbot , linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <20241231084108.1146-1-hdanton@sina.com> <20250111010103.1615-1-hdanton@sina.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250111010103.1615-1-hdanton@sina.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tjQHwTveXV1WHZryxqVhVR6pSn50j3giTzPEoeyXdwQ_1736589801 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D878D40004 X-Stat-Signature: qj1gqzxktzzft7cw6roe38ybz1dymwmf X-Rspam-User: X-HE-Tag: 1736589804-983315 X-HE-Meta: U2FsdGVkX1/IbHlBN6XCBrF//yaWgh1WrHJB9N1c5as8iqvCK1DQpw8wWCUWotan01YYR4h9ZfarP9vO77Qnj4827KTz+IoGFbmpUolBWR0/+5J1zNA1gFrXpQL0P3TorfKRKpVQXPgPGsQc5Az9UzOxy3/GDreaHqN2ob6uXVLidqIqBHtfvmILo7RRxk50Vn0+uV12NjGLGqohXJmDztCQhr6/1lPJmwWbqLa6r6EbwiAVnVhKCe0IVmS0l8AXuEIsJQV70h3fQmsmWf3cr/lo1qRQQERN3D3vowFeWUqd03whdgz0F47pbG00LkJQsaKltjkgXYSkkGQXQToe612cgFmaWFtYIm5opISYzFHgu87r+bwHVYk3gypktBCKOOwgoqCDCB/EptoPqVu1JoYV42PfiojwrOKuj6s+8v3mDsjF6x1zPHIh0YcKABhOFxCAZVYZWWBQRy75hlaoIQRL/hAjYJOd2XKrPIotT6Q0UARhFWYjyl5sOlHZeyJS2JZbCz9xMvEJP5KBZr6JIVoqr6/hLW5CAp4yxPkNOAZjtppaK2WY3JF6HVwKsl54iBV5Y/Zf8NSziUO7uIyzwNXU1vqSViitL3syila327SbhhdabASGXntsUhpNfKefBP0fYerjorS/wFvZud2lE3otOfsJe4VrauXd/4cVLJN+CFBPDvL1efg4YR3q79U0A2D23uRaqvAmheycxRd4X3gRO558kCXinKhbYcdHhSTolgnsVyKny+OD3+MVKedNYl7uUcGnql/W7CteKFqH0pZZDnnaI9aJh5uwsCmWQjkKrS0IpUIqp/p8X6fGnDiYCE7DtMpdOqvm+bQD0014+COK1Y8buZVaJZBBUy+NSZ2ksr1fX8AzWDC0ItqelJysJXFuv1esCWvwKs9NLovghepUgWk0SBTEukhEyFoWLf839W/y78vnJ/7QOpFjZgg8rtTKylxTfCtbPmFAlma l1INwR8V CNjFMDA9Hqx6IVNvOEED05AElR8SVIjxywNH+ZVPigx+4nwnnZJcogkG8etivJz5a0CRxbZm0qL+hjlSTuKF3zeaMn9MG85QCSux/auXx6djiwO7RwKuMk0URsyRrs5kaQ/mww2wOfHUXhNFvGG/vWm1jQhAwfs9jwL6/0lPtRZEO7x5JxVZyl5hyIbhjT3bWcK80w1BHUQNfujXvglUONKOMbitKTLGFY5YAQXQG8+NadHGJEso8cSA6HNU7yv6IGuF5O40h+MlWu0OxiKNiZsP4xgWPulxeHjFj75jbgYLwBZ3MS2vjMTmy8gAnzxlnKNnoNtZced229jLThlOQOSsTqzrAoa4bx5jItdSGJBlytA0aMZZa5fKAwZx9XKUa6v3acCScKE4uqrp10aKtnRjb3j4o/3lkGsIK/375jdf2JD+4ilCElZI6hxcDGBZZwQJRqs2k4pMrNKLw3arFHKaw6R7d9yFVcy5Y+8ZBEde11NLrS1rdmHQxtwGGlaFO/QmdToFzrqC5WF0l7ym48ID7+qFW/kiwq/i2jxPaJWIaazRmpImvtF3IHGGH1Rec6b6yE/g/KAnMpDsgzHuRN6Wdv01AnVfXiT4IZdvnbYfVqzqklkLx9Wd5iboaw6FPkgpy/vctwHwVfdgR/bVzD3GZguekChISYb4l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.01.25 02:00, Hillf Danton wrote: > On Fri, 10 Jan 2025 17:35:25 +0100 David Hildenbrand >> On 31.12.24 09:41, Hillf Danton wrote: >>> On Fri, 27 Dec 2024 20:56:21 -0800 >>>> syzbot has found a reproducer for the following issue on: >>>> >>>> HEAD commit: 8155b4ef3466 Add linux-next specific files for 20241220 >>>> git tree: linux-next >>>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1652fadf980000 >>> >>> #syz test >>> >>> --- x/mm/filemap.c >>> +++ y/mm/filemap.c >>> @@ -3636,6 +3636,10 @@ static vm_fault_t filemap_map_folio_rang >>> continue; >>> skip: >>> if (count) { >>> + for (unsigned int i = 0; i < count; i++) { >>> + if (page_folio(page + i) != folio) >>> + goto out; >>> + } >> >> IIRC, count <= nr_pages. Wouldn't that mean that we somehow pass in >> nr_pages that already exceeds the given folio+start? >> >> When I last looked at this, I was not able to spot the error in the >> caller :( >> > This is a debug patch at the first place, and this hunk overlaps with the > next one. Yeah, I was rather wondering if you had any clue why that hunk might help on its own. -- Cheers, David / dhildenb