linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: js1304@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>,
	Alexander Potapenko <glider@google.com>,
	Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Sasha Levin <sasha.levin@oracle.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v3 3/9] mm/page_owner: copy last_migrate_reason in copy_page_owner()
Date: Fri, 17 Jun 2016 16:57:33 +0900	[thread overview]
Message-ID: <1466150259-27727-4-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1466150259-27727-1-git-send-email-iamjoonsoo.kim@lge.com>

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Currently, copy_page_owner() doesn't copy all the owner information.  It
skips last_migrate_reason because copy_page_owner() is used for migration
and it will be properly set soon.  But, following patch will use
copy_page_owner() and this skip will cause the problem that allocated page
has uninitialied last_migrate_reason.  To prevent it, this patch also copy
last_migrate_reason in copy_page_owner().

Link: http://lkml.kernel.org/r/1464230275-25791-3-git-send-email-iamjoonsoo.kim@lge.com
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Michal Hocko <mhocko@kernel.org>
---
 mm/page_owner.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/page_owner.c b/mm/page_owner.c
index c6cda3e..73e202f 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -118,6 +118,7 @@ void __copy_page_owner(struct page *oldpage, struct page *newpage)
 
 	new_ext->order = old_ext->order;
 	new_ext->gfp_mask = old_ext->gfp_mask;
+	new_ext->last_migrate_reason = old_ext->last_migrate_reason;
 	new_ext->nr_entries = old_ext->nr_entries;
 
 	for (i = 0; i < ARRAY_SIZE(new_ext->trace_entries); i++)
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-06-17  7:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17  7:57 [PATCH v3 0/9] reduce memory usage by page_owner js1304
2016-06-17  7:57 ` [PATCH v3 1/9] mm/compaction: split freepages without holding the zone lock js1304
2016-06-17  7:57 ` [PATCH v3 2/9] mm/page_owner: initialize page owner " js1304
2016-06-17  7:57 ` js1304 [this message]
2016-06-17  7:57 ` [PATCH v3 4/9] mm/page_owner: introduce split_page_owner and replace manual handling js1304
2016-06-17  7:57 ` [PATCH v3 5/9] tools/vm/page_owner: increase temporary buffer size js1304
2016-06-17 12:56   ` Vlastimil Babka
2016-06-17  7:57 ` [PATCH v3 6/9] mm/page_owner: use stackdepot to store stacktrace js1304
2016-10-26 13:06   ` [v3,6/9] " Sascha Silbe
2016-10-27  0:17     ` Joonsoo Kim
2016-12-22 23:37       ` Sascha Silbe
2016-06-17  7:57 ` [PATCH v3 7/9] mm/page_owner: avoid null pointer dereference js1304
2016-06-17 13:32   ` Vlastimil Babka
2016-06-24 20:19     ` Andrew Morton
2016-06-17  7:57 ` [PATCH v3 8/9] mm/page_alloc: introduce post allocation processing on page allocator js1304
2016-06-17  7:57 ` [PATCH v3 9/9] mm/page_isolation: clean up confused code js1304
2016-06-17 13:34   ` Vlastimil Babka
2016-06-24 23:19 ` [PATCH v3 0/9] reduce memory usage by page_owner Andrew Morton
2016-06-27  5:45   ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466150259-27727-4-git-send-email-iamjoonsoo.kim@lge.com \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=glider@google.com \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox