linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: [PATCH v1] mm: bad_page() checks bad_flags instead of page->flags for hwpoison page
Date: Tue, 17 May 2016 16:42:55 +0900	[thread overview]
Message-ID: <1463470975-29972-1-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)

There's a race window between checking page->flags and unpoisoning, which
taints kernel with "BUG: Bad page state". That's overkill. It's safer to
use bad_flags to detect hwpoisoned page.

Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git tmp/mm/page_alloc.c tmp_patched/mm/page_alloc.c
index 5b269bc..4e0fa37 100644
--- tmp/mm/page_alloc.c
+++ tmp_patched/mm/page_alloc.c
@@ -522,8 +522,8 @@ static void bad_page(struct page *page, const char *reason,
 	static unsigned long nr_shown;
 	static unsigned long nr_unshown;
 
-	/* Don't complain about poisoned pages */
-	if (PageHWPoison(page)) {
+	/* Don't complain about hwpoisoned pages */
+	if (bad_flags == __PG_HWPOISON) {
 		page_mapcount_reset(page); /* remove PageBuddy */
 		return;
 	}
-- 
2.7.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2016-05-17  7:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  7:42 Naoya Horiguchi [this message]
2016-05-18  7:30 ` Vlastimil Babka
2016-05-18  9:21 ` Mel Gorman
2016-05-18  9:31   ` Vlastimil Babka
2016-05-18  9:52     ` Mel Gorman
2016-05-18 10:17       ` Naoya Horiguchi
2016-05-18 10:09     ` [PATCH v2] mm: check_new_page_bad() directly returns in __PG_HWPOISON case Naoya Horiguchi
2016-05-18 14:03       ` Mel Gorman
2016-05-20 14:27         ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463470975-29972-1-git-send-email-n-horiguchi@ah.jp.nec.com \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=nao.horiguchi@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox