linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/slub.c: fix sysfs filename in comment
@ 2016-05-17  1:40 Li Peng
  2016-05-17 14:23 ` Christoph Lameter
  0 siblings, 1 reply; 2+ messages in thread
From: Li Peng @ 2016-05-17  1:40 UTC (permalink / raw)
  To: cl, penberg, rientjes, akpm; +Cc: linux-mm, linux-kernel, Li Peng

/sys/kernel/slab/xx/defrag_ratio should be remote_node_defrag_ratio.

Signed-off-by: Li Peng <lip@dtdream.com>
---
 mm/slub.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 4dbb109e..6ef1540 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1735,11 +1735,11 @@ static void *get_any_partial(struct kmem_cache *s, gfp_t flags,
 	 * may return off node objects because partial slabs are obtained
 	 * from other nodes and filled up.
 	 *
-	 * If /sys/kernel/slab/xx/defrag_ratio is set to 100 (which makes
-	 * defrag_ratio = 1000) then every (well almost) allocation will
-	 * first attempt to defrag slab caches on other nodes. This means
-	 * scanning over all nodes to look for partial slabs which may be
-	 * expensive if we do it every time we are trying to find a slab
+	 * If /sys/kernel/slab/xx/remote_node_defrag_ratio is set to 100
+	 * (which makes defrag_ratio = 1000) then every (well almost)
+	 * allocation will first attempt to defrag slab caches on other nodes.
+	 * This means scanning over all nodes to look for partial slabs which
+	 * may be expensive if we do it every time we are trying to find a slab
 	 * with available objects.
 	 */
 	if (!s->remote_node_defrag_ratio ||
-- 
1.8.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm/slub.c: fix sysfs filename in comment
  2016-05-17  1:40 [PATCH] mm/slub.c: fix sysfs filename in comment Li Peng
@ 2016-05-17 14:23 ` Christoph Lameter
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2016-05-17 14:23 UTC (permalink / raw)
  To: Li Peng; +Cc: penberg, rientjes, akpm, linux-mm, linux-kernel

On Tue, 17 May 2016, Li Peng wrote:
> /sys/kernel/slab/xx/defrag_ratio should be remote_node_defrag_ratio.

Acked-by: Christoph Lameter <cl@linux.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-17 14:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17  1:40 [PATCH] mm/slub.c: fix sysfs filename in comment Li Peng
2016-05-17 14:23 ` Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox