From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Arjan van de Ven <arjan@fenrus.demon.nl>
Cc: linux-mm@kvack.org
Subject: Re: PATCH: rewrite of invalidate_inode_pages
Date: Fri, 12 May 2000 15:35:00 +0200 (CEST) [thread overview]
Message-ID: <14620.2180.8684.529000@charged.uio.no> (raw)
In-Reply-To: <m12qFNa-000OVtC@amadeus.home.nl>
>>>>> " " == Arjan van de Ven <arjan@fenrus.demon.nl> writes:
>> Could you please look into changing the name of
>> invalidate_inode_pages() to invalidate_pages_noblock() or
>> something like that? Since NFS is the only place where this
>> function is used, a change of name should not break any other
>> code.
> I'd vote for "invalidate_unlocked_inode_pages", as it also
> suggests that the locked pages aren't invalidated.
That sounds very good to me. Just so long as the name becomes more
self-documenting than it is now.
Intelligent people are making mistakes about what we want to do with
this function, so it definitely needs to be documented more clearly.
Cheers,
Trond
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-05-12 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-11 21:40 Juan J. Quintela
2000-05-11 21:47 ` Linus Torvalds
2000-05-11 21:56 ` Juan J. Quintela
2000-05-11 22:22 ` Linus Torvalds
2000-05-12 1:01 ` Juan J. Quintela
2000-05-12 2:02 ` PATCH: new page_cache_get() (try 2) Juan J. Quintela
2000-05-11 22:22 ` PATCH: rewrite of invalidate_inode_pages Ingo Molnar
2000-05-11 22:34 ` Trond Myklebust
2000-05-11 22:54 ` Juan J. Quintela
2000-05-11 23:17 ` Trond Myklebust
2000-05-11 23:28 ` Juan J. Quintela
2000-05-11 23:55 ` Trond Myklebust
2000-05-12 11:28 ` John Cavan
2000-05-12 11:37 ` Juan J. Quintela
2000-05-12 12:51 ` Trond Myklebust
2000-05-12 13:21 ` Arjan van de Ven
2000-05-12 13:35 ` Trond Myklebust [this message]
2000-05-12 17:57 ` Juan J. Quintela
2000-05-12 13:30 ` Juan J. Quintela
2000-05-11 22:05 ` Jeff V. Merkey
2000-05-11 22:28 ` Trond Myklebust
2000-05-11 22:43 ` Juan J. Quintela
2000-05-11 22:56 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14620.2180.8684.529000@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=arjan@fenrus.demon.nl \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox