From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 699A36B0005 for ; Tue, 29 Mar 2016 18:03:03 -0400 (EDT) Received: by mail-pa0-f48.google.com with SMTP id tt10so23878675pab.3 for ; Tue, 29 Mar 2016 15:03:03 -0700 (PDT) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com. [2607:f8b0:400e:c03::22f]) by mx.google.com with ESMTPS id dd5si1150396pad.117.2016.03.29.15.03.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Mar 2016 15:03:02 -0700 (PDT) Received: by mail-pa0-x22f.google.com with SMTP id tt10so23878466pab.3 for ; Tue, 29 Mar 2016 15:03:02 -0700 (PDT) From: Yu Zhao Subject: [PATCH] zsmalloc: use workqueue to destroy pool in zpool callback Date: Tue, 29 Mar 2016 15:02:57 -0700 Message-Id: <1459288977-25562-1-git-send-email-yuzhao@google.com> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim , Nitin Gupta Cc: Sergey Senozhatsky , linux-mm@kvack.org, Yu Zhao zs_destroy_pool() might sleep so it shouldn't be used in zpool destroy callback which can be invoked in softirq context when zsmalloc is configured to work with zswap. BUG: scheduling while atomic: swapper/6/0/0x00000100 ... Call Trace: [] dump_stack+0x4d/0x63 [] __schedule_bug+0x46/0x54 [] __schedule+0x334/0x3d3 [] schedule+0x37/0x80 [] schedule_preempt_disabled+0xe/0x10 [] mutex_optimistic_spin+0x185/0x1c0 [] __mutex_lock_slowpath+0x2b/0x100 [] ? __drain_alien_cache+0x9e/0xf0 [] mutex_lock+0x1b/0x2f [] kmem_cache_destroy+0x50/0x130 [] zs_destroy_pool+0x85/0xe0 [] zs_zpool_destroy+0xe/0x10 [] zpool_destroy_pool+0x54/0x70 [] __zswap_pool_release+0x62/0x90 [] rcu_process_callbacks+0x22e/0x640 [] ? run_timer_softirq+0x3e/0x280 [] __do_softirq+0xcb/0x250 [] irq_exit+0x9c/0xb0 [] smp_apic_timer_interrupt+0x6a/0x80 [] apic_timer_interrupt+0x7f/0x90 [] ? cpuidle_enter_state+0xb2/0x200 [] ? cpuidle_enter_state+0x95/0x200 [] cpuidle_enter+0x17/0x20 [] cpu_startup_entry+0x235/0x320 [] start_secondary+0xeb/0x100[ 218.606157] Signed-off-by: Yu Zhao --- mm/zsmalloc.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index e72efb1..fca5366 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -262,6 +262,9 @@ struct zs_pool { #ifdef CONFIG_ZSMALLOC_STAT struct dentry *stat_dentry; #endif +#ifdef CONFIG_ZPOOL + struct work_struct zpool_destroy_work; +#endif }; /* @@ -327,9 +330,17 @@ static void *zs_zpool_create(const char *name, gfp_t gfp, return zs_create_pool(name, gfp); } +static void zs_zpool_destroy_work(struct work_struct *work) +{ + zs_destroy_pool(container_of(work, struct zs_pool, zpool_destroy_work)); +} + static void zs_zpool_destroy(void *pool) { - zs_destroy_pool(pool); + struct zs_pool *zs_pool = pool; + + INIT_WORK(&zs_pool->zpool_destroy_work, zs_zpool_destroy_work); + schedule_work(&zs_pool->zpool_destroy_work); } static int zs_zpool_malloc(void *pool, size_t size, gfp_t gfp, -- 2.8.0.rc3.226.g39d4020 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org