From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AB1E7717D for ; Tue, 10 Dec 2024 01:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44CBF6B00D1; Mon, 9 Dec 2024 20:21:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D55A6B00D2; Mon, 9 Dec 2024 20:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29D526B00D3; Mon, 9 Dec 2024 20:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 048956B00D1 for ; Mon, 9 Dec 2024 20:21:38 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F61A8016B for ; Tue, 10 Dec 2024 01:21:38 +0000 (UTC) X-FDA: 82877296614.18.9BC2629 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf17.hostedemail.com (Postfix) with ESMTP id 97F9040009 for ; Tue, 10 Dec 2024 01:21:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733793686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEdVZ8+42gdybFDpHworjRqyxUM/yIbz/zAs/t6WiS0=; b=LdlmfnhO6oNids4MaNJU5SMTYrt3V2sMAjMcOoMiB1bTcOtlW6b1+l4U7rVHf9fAViNj0c MKy6p1r+4MqgLZUlJEecH3VGv37/FcNQ4rDgwdjgVJWqbc1OFkkUPBg27FtvW5+jgXS3re XRtLudx6+zSEBBxq9d844PbPF46KE/c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733793686; a=rsa-sha256; cv=none; b=Lk1JVp5VuFVj+QIsUtXvMA+O9FXf++mQS0+iwlGGALtmdAAlgkgg8NjUOsSGw8aPhYfsSD oJMX0dxHKex+e+KtACvp3zNMzLtOVeuOnp5j5KWnhH8don5qk8xKpJIES2Uxio0bdRxSzh rfEK3uFpWd7HB+7TSLfuAmdHgpLmGXw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Y6gqY21kkz1T6kl; Tue, 10 Dec 2024 09:19:05 +0800 (CST) Received: from kwepemg200008.china.huawei.com (unknown [7.202.181.35]) by mail.maildlp.com (Postfix) with ESMTPS id D1B3C14010C; Tue, 10 Dec 2024 09:21:29 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemg200008.china.huawei.com (7.202.181.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 10 Dec 2024 09:21:28 +0800 Message-ID: <1457e171-17d0-7e1c-1526-10643ca76399@huawei.com> Date: Tue, 10 Dec 2024 09:21:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 0/2] userfaultfd: handle few NULL check inline Content-Language: en-US To: Lorenzo Stoakes CC: , , , , , , , , , , , References: <20241209132549.2878604-1-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemg200008.china.huawei.com (7.202.181.35) X-Stat-Signature: 5d14cfhqk336ydf9oq4emm6kyifs6peu X-Rspamd-Queue-Id: 97F9040009 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733793678-939844 X-HE-Meta: U2FsdGVkX185CepGjl8jR2NAa5oisbdXNTSxex/vOOmPSzQ5OZ4Ms/NLdpyuI9x4rJzNqE8XsJob4uBBM0OF8pQrftXcSOQK68vIfkYWWFetiXLRDHDSytZeE2eLnDbJSRcg4khl6cdksKraDZCrRYW5pRCDZRzUQNh/ijidCcYPU3YBco2VZ0jO2n2gq/i8KCqqTSrflW3RYiDN2ILQuLL8KH5NuOBtEgWjBgAwY3scmGCpmxOHQfTTHuspiH2DHje44hm86hD3jBPIZ52zRGP7HOJKZUX+DUpZFvf55Z8qETHq6Okm2Raig8kXXDJ2ylnDgq+oYCU9U2BjYVjegeCLIz1Tazlcc10rv2+OU4awfLzQXDX4RWAU38hz035jbPix/WTNsL7Xc0GNVTvaU1WKF9o165b31CSeL3b1tlkDfPWKQsQTaNV0WR+S2FlyoA/tUyFJjv6pkRM7XmnPShiqAW5y7aE1fNSEy1DtDd3JHfpMXn9ML1RMusEif1ox6tMvBniMb1TPL0IZGtNhZyP/zwDSY6XTQP68/2eiBbAq9G1DviMX99H/QgImW7MAXyjjyNuHCDk3CDC/Tl3NvQGEpZ1jOf3TwdtbCOuPGD7itf2yaP9JIm7pASk9M1XN8Lb+GghK66bG9Rog1jloQetQNV+3jP+BZ3UPjgrIv8zBFUSjk1AMdS2taYZ9iWI9ME4HtKI6zq/s6FMtk/0CdrR8sw+i7Ydij5fuQrS/59sUa0N/fxF4H7K5gc7yV1gPabm5n9n8GPLqdQ8Om5UZrcrnFa62P7itaO7mLfSlJp1GWz9MV//IVrUfnTwunVhG/VEgkIN4phNLmb8qDSH6WJCzSrJwg2z0Qh1Pg8vydYABO+4Fk6YPV7nGOSnxgoFJoqJTqRlftNFGQBKKlT5Ps83l7yDeMG2y9hgprv3++JJtqOMeOajqdblccmzjCJENs84tXokTOnAHM6XRBlU 3ZCvNASk yUj2e8ivXwqyIlLIBUEpSDB0lakAh4NLVv2IroNlGk0wiVcW1ujw/BNBIN02x7B2YpNJxLBCdqPuttjSH4Q6aRC6S31b6WOzSsUHpuzl7qcFf1+DS1lOmOgab0bJhlP2IcsVtP76EhN763O+24mAWfB5XwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.010618, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/9 21:42, Lorenzo Stoakes wrote: > On Mon, Dec 09, 2024 at 09:25:47PM +0800, Jinjie Ruan wrote: >> Handle dup_userfaultfd() and anon_vma_fork() NULL check inline to >> save some function call overhead. The Unixbench single core process >> create has 1% improve with these patches. >> >> Jinjie Ruan (2): >> userfaultfd: handle dup_userfaultfd() NULL check inline >> mm, rmap: handle anon_vma_fork() NULL check inline >> >> fs/userfaultfd.c | 5 +---- >> include/linux/rmap.h | 12 +++++++++++- >> include/linux/userfaultfd_k.h | 11 ++++++++++- >> mm/rmap.c | 6 +----- >> 4 files changed, 23 insertions(+), 11 deletions(-) >> >> -- >> 2.34.1 >> > > Coincidentally I've just diagosed a rather nasty bug in this code [0], so > could we hold off on this change for just a little bit until we can get a > fix out for this please? > > I'd rather not complicate anything until we're sure we won't need to change > this. Sure, fix the bugs is a more urgent problem. Thanks! > > Thanks! > > > [0]:https://lore.kernel.org/linux-mm/aa2c1930-becc-4bc5-adfb-96e88290acc7@lucifer.local/ >