linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: js1304@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Mel Gorman <mgorman@suse.de>,
	Laura Abbott <lauraa@codeaurora.org>,
	Minchan Kim <minchan@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH 1/6] mm/page_alloc: fix same zone check in __pageblock_pfn_to_page()
Date: Mon, 14 Mar 2016 16:31:32 +0900	[thread overview]
Message-ID: <1457940697-2278-2-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1457940697-2278-1-git-send-email-iamjoonsoo.kim@lge.com>

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>

There is a system that node's pfn are overlapped like as following.

-----pfn-------->
N0 N1 N2 N0 N1 N2

Therefore, we need to care this overlapping when iterating pfn range.

In __pageblock_pfn_to_page(), there is a check for this but it's
not sufficient. This check cannot distinguish the case that zone id
is the same but node id is different. This patch fixes it.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/page_alloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 8120f07..93293b4 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1173,8 +1173,7 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn,
 
 	end_page = pfn_to_page(end_pfn);
 
-	/* This gives a shorter code than deriving page_zone(end_page) */
-	if (page_zone_id(start_page) != page_zone_id(end_page))
+	if (zone != page_zone(end_page))
 		return NULL;
 
 	return start_page;
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-03-14  7:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  7:31 [PATCH 0/6] Add zone overlapping check js1304
2016-03-14  7:31 ` js1304 [this message]
2016-03-21 11:37   ` [PATCH 1/6] mm/page_alloc: fix same zone check in __pageblock_pfn_to_page() Mel Gorman
2016-03-22  5:02     ` Joonsoo Kim
2016-03-14  7:31 ` [PATCH 2/6] mm/hugetlb: add same zone check in pfn_range_valid_gigantic() js1304
2016-03-23 14:38   ` Vlastimil Babka
2016-03-14  7:31 ` [PATCH 3/6] mm/memory_hotplug: add comment to some functions related to memory hotplug js1304
2016-03-23 14:38   ` Vlastimil Babka
2016-03-14  7:31 ` [PATCH 4/6] mm/vmstat: add zone range overlapping check js1304
2016-03-23 14:47   ` Vlastimil Babka
2016-03-24  0:08     ` Joonsoo Kim
2016-03-14  7:31 ` [PATCH 5/6] mm/page_owner: " js1304
2016-03-14  7:31 ` [PATCH 6/6] power: " js1304

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457940697-2278-2-git-send-email-iamjoonsoo.kim@lge.com \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=lauraa@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox