From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov@virtuozzo.com
Cc: linux-mm@kvack.org, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: [PATCH] mm: memcontrol: drop unnecessary task_will_free_mem() check.
Date: Wed, 9 Mar 2016 00:15:10 +0900 [thread overview]
Message-ID: <1457450110-6005-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> (raw)
Since mem_cgroup_out_of_memory() is called by
mem_cgroup_oom_synchronize(true) via pagefault_out_of_memory() via
page fault, and possible allocations between setting PF_EXITING and
calling exit_mm() are tty_audit_exit() and taskstats_exit() which will
not trigger page fault, task_will_free_mem(current) in
mem_cgroup_out_of_memory() is never true.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
mm/memcontrol.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index ae8b81c..701bef1 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1254,11 +1254,11 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
mutex_lock(&oom_lock);
/*
- * If current has a pending SIGKILL or is exiting, then automatically
- * select it. The goal is to allow it to allocate so that it may
- * quickly exit and free its memory.
+ * If current has a pending SIGKILL, then automatically select it.
+ * The goal is to allow it to allocate so that it may quickly exit
+ * and free its memory.
*/
- if (fatal_signal_pending(current) || task_will_free_mem(current)) {
+ if (fatal_signal_pending(current)) {
mark_oom_victim(current);
goto unlock;
}
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-03-08 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 15:15 Tetsuo Handa [this message]
2016-03-08 18:14 ` Johannes Weiner
2016-03-08 23:05 ` Tetsuo Handa
2016-03-09 10:08 ` Michal Hocko
2016-03-09 10:08 ` Michal Hocko
2016-03-09 10:05 ` Michal Hocko
2016-03-10 11:15 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457450110-6005-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox