linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Li Zhang <zhlcindy@gmail.com>,
	akpm@linux-foundation.org, vbabka@suse.cz,
	mgorman@techsingularity.net, khandual@linux.vnet.ibm.com,
	aneesh.kumar@linux.vnet.ibm.com
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Li Zhang <zhlcindy@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] powerpc/mm: Enable page parallel initialisation
Date: Tue, 08 Mar 2016 20:36:34 +1100	[thread overview]
Message-ID: <1457429794.31524.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1457409354-10867-3-git-send-email-zhlcindy@gmail.com>

Hi Li,

On Tue, 2016-03-08 at 11:55 +0800, Li Zhang wrote:

> From: Li Zhang <zhlcindy@linux.vnet.ibm.com>
>
> Parallel initialisation has been enabled for X86, boot time is
> improved greatly. On Power8, it is improved greatly for small
> memory. Here is the result from my test on Power8 platform:
>
> For 4GB memory: 57% is improved, boot time as the following:
> with patch: 10s, without patch: 24.5s

This isn't worded quite right, and the numbers are a bit off.

old = 24.5
new = 10

So the improvement is 14.5 (seconds).

That means the improvement (14.5) as a percentage of the original boot time is:

 = 14.5 / 24.5 * 100
 = 59.183673469387756
 = 59%

So you would say:

  For 4GB of memory, boot time is improved by 59%, from 24.5s to 10s.

> For 50GB memory: 22% is improved, boot time as the following:
> with patch: 43.8s, without patch: 56.8s

  For 50GB memory, boot time is improved by 22%, from 56.8s to 43.8s.

> Acked-by: Mel Gorman <mgorman@techsingularity.net>
> Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> ---
>  * Add boot time details in change log.
>  * Please apply this patch after [PATCH 1/2] mm: meminit: initialise
>     more memory for inode/dentry hash tables in early boot, because
>    [PATCH 1/2] is to fix a bug which can be reproduced on Power.

Given that, I think it would be best if Andrew merged both of these patches.
Because this patch is pretty trivial, whereas the patch to mm/ is less so.

Is that OK Andrew?

For this one:

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-03-08  9:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  3:55 [PATCH 0/2] mm: Enable page parallel initialisation for Power Li Zhang
2016-03-08  3:55 ` [PATCH 1/2] mm: meminit: initialise more memory for inode/dentry hash tables in early boot Li Zhang
2016-03-08 13:25   ` Vlastimil Babka
2016-03-08  3:55 ` [PATCH 2/2] powerpc/mm: Enable page parallel initialisation Li Zhang
2016-03-08  9:36   ` Michael Ellerman [this message]
2016-03-09  2:06     ` Li Zhang
2016-03-09 21:42     ` Andrew Morton
2016-03-10  0:28       ` Michael Ellerman
2016-03-08 14:45 ` [PATCH 0/2] mm: Enable page parallel initialisation for Power Balbir Singh
2016-03-09  4:17   ` Li Zhang
2016-03-09  4:28     ` Balbir Singh
2016-03-09  5:50       ` Li Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457429794.31524.1.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    --cc=zhlcindy@gmail.com \
    --cc=zhlcindy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox