From: "Stephen C. Tweedie" <sct@redhat.com>
To: Chuck Lever <cel@monkey.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-mm@kvack.org, Stephen Tweedie <sct@redhat.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] madvise() against 2.3.52-3
Date: Wed, 15 Mar 2000 19:12:21 +0000 (GMT) [thread overview]
Message-ID: <14543.57493.860685.448837@dukat.scot.redhat.com> (raw)
In-Reply-To: <Pine.BSO.4.10.10003141806190.19943-100000@funky.monkey.org>
Hi,
On Tue, 14 Mar 2000 18:13:19 -0500 (EST), Chuck Lever <cel@monkey.org>
said:
> + lock_kernel(); /* is this really necessary? */
> +
> + flush_cache_range(vma->vm_mm, start, end);
> + zap_page_range(vma->vm_mm, start, end - start);
> + flush_tlb_range(vma->vm_mm, start, end);
> +
> + unlock_kernel();
I'd have thought we'd be safe without it --- the zap_page_range()
already takes the page table lock, The flush_tlb_range should be safe
on SMP without the kernel lock now, shouldn't it? We certainly take a
tlb lock on Intel to guard this --- I'm not sure if it's 100% safe on
other architectures.
--Stephen
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-03-15 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-03-14 23:13 Chuck Lever
2000-03-15 19:12 ` Stephen C. Tweedie [this message]
2000-03-16 19:58 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14543.57493.860685.448837@dukat.scot.redhat.com \
--to=sct@redhat.com \
--cc=cel@monkey.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox