From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH v1] mm: soft-offline: exit with failure for non anonymous thp
Date: Tue, 12 Jan 2016 12:10:43 +0900 [thread overview]
Message-ID: <1452568245-10412-1-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <20160108123300.843d370916d3248be297d831@linux-foundation.org>
On Fri, Jan 08, 2016 at 12:33:00PM -0800, Andrew Morton wrote:
> On Fri, 8 Jan 2016 16:24:02 +0900 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
>
> > Currently memory_failure() doesn't handle non anonymous thp case, because we
> > can hardly expect the error handling to be successful, and it can just hit
> > some corner case which results in BUG_ON or something severe like that.
> > This is also a case for soft offline code, so let's make it in the same way.
> >
> > ...
> >
> > --- v4.4-rc8/mm/memory-failure.c
> > +++ v4.4-rc8_patched/mm/memory-failure.c
> > @@ -1751,9 +1751,11 @@ int soft_offline_page(struct page *page, int flags)
> > return -EBUSY;
> > }
> > if (!PageHuge(page) && PageTransHuge(hpage)) {
> > - if (PageAnon(hpage) && unlikely(split_huge_page(hpage))) {
> > - pr_info("soft offline: %#lx: failed to split THP\n",
> > - pfn);
> > + if (!PageAnon(hpage) || unlikely(split_huge_page(hpage))) {
> > + if (!PageAnon(hpage))
> > + pr_info("soft offline: %#lx: non anonymous thp\n", pfn);
> > + else
> > + pr_info("soft offline: %#lx: thp split failed\n", pfn);
> > if (flags & MF_COUNT_INCREASED)
> > put_hwpoison_page(page);
> > return -EBUSY;
>
> Kirill's
> http://ozlabs.org/~akpm/mmots/broken-out/thp-mm-split_huge_page-caller-need-to-lock-page.patch
> mucks with this code as well. Could you please redo this patch against
> linux-next?
OK, I did it, which will come after this email.
Thanks,
Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-12 3:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 7:24 Naoya Horiguchi
2016-01-08 20:33 ` Andrew Morton
2016-01-12 3:10 ` Naoya Horiguchi [this message]
2016-01-12 3:10 ` [PATCH v2 1/2] mm: soft-offline: clean up soft_offline_page() Naoya Horiguchi
2016-01-12 3:10 ` [PATCH v2 2/2] mm: soft-offline: exit with failure for non anonymous thp Naoya Horiguchi
2016-01-12 23:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452568245-10412-1-git-send-email-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nao.horiguchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox