From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC3CC27C40 for ; Thu, 24 Aug 2023 06:24:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3308828007F; Thu, 24 Aug 2023 02:24:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8E98E0011; Thu, 24 Aug 2023 02:24:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1590028007F; Thu, 24 Aug 2023 02:24:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 031BA8E0011 for ; Thu, 24 Aug 2023 02:24:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B7420401ED for ; Thu, 24 Aug 2023 06:24:33 +0000 (UTC) X-FDA: 81158009226.19.05480C9 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 8E4E014000C for ; Thu, 24 Aug 2023 06:24:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WC7DtczI; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692858271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YAWLL6d+tB1TW/sa+M7W81IeOtWmeLLF2BjX95heF8Y=; b=vISjo3xBZE0WtfoFhusW5DITB3uLlCffHWt1gTFQYnASjWUgjCLU8XtWh2i4o8z9pMw7r2 ZrP5bZYQ3qwuYe1LVTiSa1b04Bq60H9IHGE/UOjJz7HxM9VK2m6xY+BvekLkP9Olbm+wuj iRp9Ln18StdcxMBJo45kMJVg/unMDBA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692858271; a=rsa-sha256; cv=none; b=kzqOjYBQJzL6wHFpJEMppe1lgRemhhGzoYcWVHAXGRHybspMRAIeNp3b8k3VQodHlfBYGd SwRxHms4EoFF6pzXyu362IjWJsNvIrqe79jCJV7wbi/Y7eWWeGCJkd28le/oV/zhGQVYln tGKjzdmjzNqFQbo3jSzvCeFgtra/Hck= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WC7DtczI; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-68bbd45d0d5so331624b3a.1 for ; Wed, 23 Aug 2023 23:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1692858269; x=1693463069; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YAWLL6d+tB1TW/sa+M7W81IeOtWmeLLF2BjX95heF8Y=; b=WC7DtczIl2huODCCK2FUQBPFySR8Fgdq+0RzN3EpYCF6xc5qlgt5yYNUyGMzGD3Vfd sCmovMwZKx7eCaX+kb4GhOATxvPvZalq8HdXwztGZ/H374MK4JcYUpPJJsgpKNLIKxot DmBT4zE6v8oseL1JDCpoVcqcxZf5N5NE7wvMO3NRJDeqxBq3NCwRJPiax64qfPuWSob5 mcJU3k0lorHBX5pSNWGBJw+GJKMZc4VAy8jbjqfXszKYvDjyOYUFsPD/PZLQycXFE2uX l6MCDqrZ3yavMHHn+nS97IILA+7i5RFenYBam2Bp94XJlGvvguZGUp/ZdPOc/jOY5cia xE5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692858269; x=1693463069; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YAWLL6d+tB1TW/sa+M7W81IeOtWmeLLF2BjX95heF8Y=; b=TWLwcBm+Ki9KP2hTElcdSGFYsJvoh9YIoeUK1XdKtEvI85NbEKzK7fc8DhXsMBPK7l C+M0lBbdwTdedS1XWlSF1wHydTOvuAX75rp8/qykuC2wRYcBd6uYVEtmie03wP+OAG9M 1KR+M1IDo4obYtIdSB7WYvAjU039Tyc/lPv6CtC0ICNGUEptB1673rtUmO3yS/uQhHpf +O66STV/hliIJPn+4sT1j8INB5S3QqpPVBa1qcoBsGqRU9pGctxF/m0qn2LGJ2/gJS6I 5VSCcaZPyRtScrEB5ClA/2+jvjAJOB6LoL297/teDUddN9rYfr8X4k7YYJhi97Z5iN/h HNcQ== X-Gm-Message-State: AOJu0YztWZJUiVSso2dNb2eFOGe/0GrdDXJzjvhe1dSidp8WB0HoCYQB /wzhJvASBqeB2nftoszn/rYQqw== X-Google-Smtp-Source: AGHT+IEs+IcDk16YZ3T8sMPMS+c78NyGGAK7cNqbsAY3c0HgSGha1qj1+0CJyvlKa4AYIkTewnV0cA== X-Received: by 2002:a05:6a20:8e19:b0:13e:1d49:723c with SMTP id y25-20020a056a208e1900b0013e1d49723cmr15644854pzj.2.1692858269010; Wed, 23 Aug 2023 23:24:29 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id ey6-20020a056a0038c600b00686f048bb9dsm6577558pfb.74.2023.08.23.23.24.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 23:24:28 -0700 (PDT) Message-ID: <144fd7ac-154f-79b9-5483-56b15941f62f@bytedance.com> Date: Thu, 24 Aug 2023 14:24:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v5 05/45] xenbus/backend: dynamically allocate the xen-backend shrinker Content-Language: en-US To: Juergen Gross Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Muchun Song , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <20230824034304.37411-1-zhengqi.arch@bytedance.com> <20230824034304.37411-6-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8E4E014000C X-Rspam-User: X-Stat-Signature: m75d3md938c35ise6nqdyna91m1fat47 X-Rspamd-Server: rspam03 X-HE-Tag: 1692858270-599605 X-HE-Meta: U2FsdGVkX19DfwEBz7fuYieNTsFhtmh2zYhyMBw0LCVvFn73GQYUB9xoMUKKdjwuisHCW3aZsX6w8ZzNlERk/eRtiyORDAF/1DNgeH7s+YSTUSc4PG3Aqx1AC+Wc8mMAdaM4r5Qoz2ZD0hcQ6yhnO4U8DjIEB1DfL2xzb0zdIMqTeFI0DEbOnRfEcr74OkMdWdW6SQ6FxxwFFVhfIn36he/3Hnv5usgIr7nMkKNOUMgoICXf7szUB5a3cozzVUXi9VE7rx2whHhskKb4FjjXXWPDsf5edvgJBEtcsleeyttIMVF45Ttup7+46e8YAoxLMoqG72Kg1aRBm2Vxdit1lxNsb3jY/0if9sqPRaeI+XPM31t6QjmMF+1lLx9GiH9ptG741hJAEnhZjqe5ztnQ7KVD5KSN7WGfSYeT39mSMUEoE3mPvF/fRqQUXo+nK3K8sFWS8AjSXDpERAch8bRL1z2nhznN86W9lkv0w5009ERK9iun/avwERFXs4XQQ4ONRT0LaKDFobbzthMSQR3OeFYuCVN3qpe4mA9suKklzCpncMBtkRFUAkKWFwBeaAhElELITo3PX1HkwmIeU2OarSy/NyVNnmA8u7XZQwFdCElwgUWu6buLTP4tVcXKcgYovmHQQfyOfaLKIRrI1hceMdEn4+1D9xTJ/uNPRACExInfdhNOdeRUmgxFQTfSfM4ZmLaj1yaHRCS8m8O3qUHJgoA4NxV0N7DalVuwYFiCpfB4Vpc1PWyTRVxl7bv+dz5Qb6BXhSOQfxwx2ZDjw1B72/9qMsQi3oDjZaRreTC/QgsV/OYpoDf+KUWgb8xaQeDE3LDO+Ao0DBf8qDcFyzS2Te+zpgt7wfTH3Eury1sSef7WUHcknbrr2OeqxBtGy1/vVzrxFw2oC5g/24M46WquB6L3rWklQq4W6dPN8UPqTQfNj9zd2aTWiU8/gfOKVJf4anR1YO62v5EsvA3qaSC hrOuOKcn qchtij/0xx51P+6ehdMLBLBql3LY1nOcdjoul9bnqjpyBgOIB/fT+rIflOUVB8gtkKz5kZOaLsLDl2TJf+M09ZEfgh5rhz8nqfducR6acCbJGlO8j5HxnCTEH7uluyZzeJFqFTF8YUxVHqgCIR6ZhfpfsLIuvKnsJb7A4rvLbuz+ufb3oAUil/ab5LHA50cF8c2rSIFtTc+2wIJG/XmScBsZGCT2dQ6k2XN/vGAI7bP07+5hGdtWFLIMifbxK6nDr/FURIaXswzN29zvpODHTLTmQIf1rpZAU909HfNx+Inp9zD7BSEcxut5bUuGh9KguKiYm2i3Mfy2AIQufwHT+mQw8jLsiw7E1gglJ4FwhpqRh5+fJfBw3Cac0KEf/CQtCN8POqq2PWgfH/TZaNbtBYAZCICwrOf+tRdi/8qzYBlk09izInfKMSztBF7lpOva8x1f+pFylLKXAfYl7vOHkzrvxfMt7+L4auqFAckRpGVGQUYU4KwM2Mppw6+GAwoiBrJmeiQu/joajUCCRfj8/WvcvCYH1GEZHuijlz9shyb8Qmce7Tm/oSNLhBAxK/kp5EsBplys7OoN645TkcIQhBf81JG0R8n7yqGzieCajseyH4K+rpyXWKDap0CAER+6gknr8gMaIZi2CNvcfMV7kT0tsWHioLRwsR9dA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Juergen, On 2023/8/24 14:00, Juergen Gross wrote: > On 24.08.23 05:42, Qi Zheng wrote: >> Use new APIs to dynamically allocate the xen-backend shrinker. >> >> Signed-off-by: Qi Zheng >> Reviewed-by: Muchun Song >> CC: Juergen Gross >> CC: Stefano Stabellini >> CC: Oleksandr Tyshchenko >> CC: xen-devel@lists.xenproject.org > > Acked-by: Juergen Gross Thanks for your review! > > Just one note: it seems as if most users will set seeks to DEFAULT_SEEKS. > Wouldn't it be better to do this in shrinker_alloc() and let only callers > who want a different value overwrite that? I think it makes sense, will do. Thanks, Qi > > > Juergen