From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by kanga.kvack.org (Postfix) with ESMTP id CAAC56B0253 for ; Thu, 3 Dec 2015 12:17:30 -0500 (EST) Received: by pabfh17 with SMTP id fh17so74192098pab.0 for ; Thu, 03 Dec 2015 09:17:30 -0800 (PST) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com. [2607:f8b0:400e:c03::231]) by mx.google.com with ESMTPS id uw2si13013585pac.223.2015.12.03.09.17.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Dec 2015 09:17:29 -0800 (PST) Received: by pacdm15 with SMTP id dm15so71995168pac.3 for ; Thu, 03 Dec 2015 09:17:29 -0800 (PST) Message-ID: <1449163048.25029.2.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation From: Eric Dumazet Date: Thu, 03 Dec 2015 09:17:28 -0800 In-Reply-To: <20151203155905.GA31974@amd> References: <20151126163413.GA3816@amd> <20151127082010.GA2500@dhcp22.suse.cz> <20151128145113.GB4135@amd> <20151203155905.GA31974@amd> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Pavel Machek Cc: Michal Hocko , davem@davemloft.net, Andrew Morton , kernel list , jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org, "Rafael J. Wysocki" , linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com, ebiederm@xmission.com On Thu, 2015-12-03 at 16:59 +0100, Pavel Machek wrote: > atl1c driver is doing order-4 allocation with GFP_ATOMIC > priority. That often breaks networking after resume. Switch to > GFP_KERNEL. Still not ideal, but should be significantly better. > > atl1c_setup_ring_resources() is called from .open() function, and > already uses GFP_KERNEL, so this change is safe. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > index 2795d6d..afb71e0 100644 > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > @@ -1016,10 +1016,10 @@ static int atl1c_setup_ring_resources(struct atl1c_adapter *adapter) > sizeof(struct atl1c_recv_ret_status) * rx_desc_count + > 8 * 4; > > - ring_header->desc = pci_alloc_consistent(pdev, ring_header->size, > - &ring_header->dma); > + ring_header->desc = dma_alloc_coherent(&pdev->dev, ring_header->size, > + &ring_header->dma, GFP_KERNEL); > if (unlikely(!ring_header->desc)) { > - dev_err(&pdev->dev, "pci_alloc_consistend failed\n"); > + dev_err(&pdev->dev, "could not get memory for DMA buffer\n"); > goto err_nomem; > } > memset(ring_header->desc, 0, ring_header->size); > > So this memset() will really require a different patch to get removed ? Sigh, not sure why I review patches. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org