From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: akpm@linux-foundation.org
Cc: bhe@redhat.com, dan.j.williams@intel.com,
dave.hansen@linux.intel.com, dave@stgolabs.net,
dhowells@redhat.com, dingel@linux.vnet.ibm.com,
hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com,
iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com,
mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com,
n-horiguchi@ah.jp.nec.com, penberg@kernel.org,
rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org,
tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/mmzone: memmap_valid_within can be boolean
Date: Wed, 18 Nov 2015 09:38:20 +0800 [thread overview]
Message-ID: <1447810700-2535-1-git-send-email-baiyaowei@cmss.chinamobile.com> (raw)
In-Reply-To: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com>
This patch makes memmap_valid_within return bool due to this
particular function only using either one or zero as its return
value.
No functional change.
Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
include/linux/mmzone.h | 6 +++---
mm/mmzone.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 9963846..b9b59bb8 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1202,13 +1202,13 @@ unsigned long __init node_memmap_size_bytes(int, unsigned long, unsigned long);
* the zone and PFN linkages are still valid. This is expensive, but walkers
* of the full memmap are extremely rare.
*/
-int memmap_valid_within(unsigned long pfn,
+bool memmap_valid_within(unsigned long pfn,
struct page *page, struct zone *zone);
#else
-static inline int memmap_valid_within(unsigned long pfn,
+static inline bool memmap_valid_within(unsigned long pfn,
struct page *page, struct zone *zone)
{
- return 1;
+ return true;
}
#endif /* CONFIG_ARCH_HAS_HOLES_MEMORYMODEL */
diff --git a/mm/mmzone.c b/mm/mmzone.c
index 7d87ebb..52687fb 100644
--- a/mm/mmzone.c
+++ b/mm/mmzone.c
@@ -72,16 +72,16 @@ struct zoneref *next_zones_zonelist(struct zoneref *z,
}
#ifdef CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
-int memmap_valid_within(unsigned long pfn,
+bool memmap_valid_within(unsigned long pfn,
struct page *page, struct zone *zone)
{
if (page_to_pfn(page) != pfn)
- return 0;
+ return false;
if (page_zone(page) != zone)
- return 0;
+ return false;
- return 1;
+ return true;
}
#endif /* CONFIG_ARCH_HAS_HOLES_MEMORYMODEL */
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-11-18 1:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 6:51 [PATCH 0/7] some small improvement Yaowei Bai
2015-11-16 6:51 ` [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean Yaowei Bai
2015-11-16 12:39 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 2/7] mm/hugetlb: is_file_hugepages " Yaowei Bai
2015-11-16 12:40 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 3/7] mm/memblock: memblock_is_memory/reserved " Yaowei Bai
2015-11-16 12:41 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 4/7] mm/vmscan: page_is_file_cache " Yaowei Bai
2015-11-16 10:10 ` David Rientjes
2015-11-17 2:18 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 5/7] mm/lru: remove unused is_unevictable_lru function Yaowei Bai
2015-11-16 12:43 ` Michal Hocko
2015-11-17 5:16 ` Hillf Danton
2015-11-16 6:51 ` [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai
2015-11-16 10:05 ` David Rientjes
2015-11-17 1:59 ` Yaowei Bai
2015-11-17 5:44 ` David Rientjes
2015-11-17 8:29 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 7/7] mm/mmzone: refactor memmap_valid_within Yaowei Bai
2015-11-16 12:45 ` Michal Hocko
2015-11-17 2:40 ` Yaowei Bai
2015-11-17 9:02 ` [PATCH] mm/zonelist: enumerate zonelists array index Yaowei Bai
2015-11-18 1:38 ` Yaowei Bai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447810700-2535-1-git-send-email-baiyaowei@cmss.chinamobile.com \
--to=baiyaowei@cmss.chinamobile.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=holt@sgi.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox