From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: akpm@linux-foundation.org
Cc: bhe@redhat.com, dan.j.williams@intel.com,
dave.hansen@linux.intel.com, dave@stgolabs.net,
dhowells@redhat.com, dingel@linux.vnet.ibm.com,
hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com,
iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com,
mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com,
n-horiguchi@ah.jp.nec.com, penberg@kernel.org,
rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org,
tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] mm/hugetlb: is_file_hugepages can be boolean
Date: Mon, 16 Nov 2015 14:51:21 +0800 [thread overview]
Message-ID: <1447656686-4851-3-git-send-email-baiyaowei@cmss.chinamobile.com> (raw)
In-Reply-To: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com>
This patch makes is_file_hugepages return bool to improve
readability due to this particular function only using either
one or zero as its return value.
This patch also removed the if condition to make is_file_hugepages
return directly.
No functional change.
Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
include/linux/hugetlb.h | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 685c262..204c7f5 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -265,20 +265,18 @@ struct file *hugetlb_file_setup(const char *name, size_t size, vm_flags_t acct,
struct user_struct **user, int creat_flags,
int page_size_log);
-static inline int is_file_hugepages(struct file *file)
+static inline bool is_file_hugepages(struct file *file)
{
if (file->f_op == &hugetlbfs_file_operations)
- return 1;
- if (is_file_shm_hugepages(file))
- return 1;
+ return true;
- return 0;
+ return is_file_shm_hugepages(file);
}
#else /* !CONFIG_HUGETLBFS */
-#define is_file_hugepages(file) 0
+#define is_file_hugepages(file) false
static inline struct file *
hugetlb_file_setup(const char *name, size_t size, vm_flags_t acctflag,
struct user_struct **user, int creat_flags,
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-16 6:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 6:51 [PATCH 0/7] some small improvement Yaowei Bai
2015-11-16 6:51 ` [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean Yaowei Bai
2015-11-16 12:39 ` Michal Hocko
2015-11-16 6:51 ` Yaowei Bai [this message]
2015-11-16 12:40 ` [PATCH 2/7] mm/hugetlb: is_file_hugepages " Michal Hocko
2015-11-16 6:51 ` [PATCH 3/7] mm/memblock: memblock_is_memory/reserved " Yaowei Bai
2015-11-16 12:41 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 4/7] mm/vmscan: page_is_file_cache " Yaowei Bai
2015-11-16 10:10 ` David Rientjes
2015-11-17 2:18 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 5/7] mm/lru: remove unused is_unevictable_lru function Yaowei Bai
2015-11-16 12:43 ` Michal Hocko
2015-11-17 5:16 ` Hillf Danton
2015-11-16 6:51 ` [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai
2015-11-16 10:05 ` David Rientjes
2015-11-17 1:59 ` Yaowei Bai
2015-11-17 5:44 ` David Rientjes
2015-11-17 8:29 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 7/7] mm/mmzone: refactor memmap_valid_within Yaowei Bai
2015-11-16 12:45 ` Michal Hocko
2015-11-17 2:40 ` Yaowei Bai
2015-11-17 9:02 ` [PATCH] mm/zonelist: enumerate zonelists array index Yaowei Bai
2015-11-18 1:38 ` [PATCH] mm/mmzone: memmap_valid_within can be boolean Yaowei Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447656686-4851-3-git-send-email-baiyaowei@cmss.chinamobile.com \
--to=baiyaowei@cmss.chinamobile.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=holt@sgi.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox