From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: akpm@linux-foundation.org
Cc: bhe@redhat.com, dan.j.williams@intel.com,
dave.hansen@linux.intel.com, dave@stgolabs.net,
dhowells@redhat.com, dingel@linux.vnet.ibm.com,
hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com,
iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com,
mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com,
n-horiguchi@ah.jp.nec.com, penberg@kernel.org,
rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org,
tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean
Date: Mon, 16 Nov 2015 14:51:20 +0800 [thread overview]
Message-ID: <1447656686-4851-2-git-send-email-baiyaowei@cmss.chinamobile.com> (raw)
In-Reply-To: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com>
This patch makes is_file_shm_hugepages return bool to improve
readability due to this particular function only using either
one or zero as its return value.
No functional change.
Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
include/linux/shm.h | 6 +++---
ipc/shm.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/shm.h b/include/linux/shm.h
index 6fb8016..04e8818 100644
--- a/include/linux/shm.h
+++ b/include/linux/shm.h
@@ -52,7 +52,7 @@ struct sysv_shm {
long do_shmat(int shmid, char __user *shmaddr, int shmflg, unsigned long *addr,
unsigned long shmlba);
-int is_file_shm_hugepages(struct file *file);
+bool is_file_shm_hugepages(struct file *file);
void exit_shm(struct task_struct *task);
#define shm_init_task(task) INIT_LIST_HEAD(&(task)->sysvshm.shm_clist)
#else
@@ -66,9 +66,9 @@ static inline long do_shmat(int shmid, char __user *shmaddr,
{
return -ENOSYS;
}
-static inline int is_file_shm_hugepages(struct file *file)
+static inline bool is_file_shm_hugepages(struct file *file)
{
- return 0;
+ return false;
}
static inline void exit_shm(struct task_struct *task)
{
diff --git a/ipc/shm.c b/ipc/shm.c
index 4178727..ed3027d 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -459,7 +459,7 @@ static const struct file_operations shm_file_operations_huge = {
.fallocate = shm_fallocate,
};
-int is_file_shm_hugepages(struct file *file)
+bool is_file_shm_hugepages(struct file *file)
{
return file->f_op == &shm_file_operations_huge;
}
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-16 6:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 6:51 [PATCH 0/7] some small improvement Yaowei Bai
2015-11-16 6:51 ` Yaowei Bai [this message]
2015-11-16 12:39 ` [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean Michal Hocko
2015-11-16 6:51 ` [PATCH 2/7] mm/hugetlb: is_file_hugepages " Yaowei Bai
2015-11-16 12:40 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 3/7] mm/memblock: memblock_is_memory/reserved " Yaowei Bai
2015-11-16 12:41 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 4/7] mm/vmscan: page_is_file_cache " Yaowei Bai
2015-11-16 10:10 ` David Rientjes
2015-11-17 2:18 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 5/7] mm/lru: remove unused is_unevictable_lru function Yaowei Bai
2015-11-16 12:43 ` Michal Hocko
2015-11-17 5:16 ` Hillf Danton
2015-11-16 6:51 ` [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai
2015-11-16 10:05 ` David Rientjes
2015-11-17 1:59 ` Yaowei Bai
2015-11-17 5:44 ` David Rientjes
2015-11-17 8:29 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 7/7] mm/mmzone: refactor memmap_valid_within Yaowei Bai
2015-11-16 12:45 ` Michal Hocko
2015-11-17 2:40 ` Yaowei Bai
2015-11-17 9:02 ` [PATCH] mm/zonelist: enumerate zonelists array index Yaowei Bai
2015-11-18 1:38 ` [PATCH] mm/mmzone: memmap_valid_within can be boolean Yaowei Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447656686-4851-2-git-send-email-baiyaowei@cmss.chinamobile.com \
--to=baiyaowei@cmss.chinamobile.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=holt@sgi.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox