From: Toshi Kani <toshi.kani@hpe.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
akpm@linux-foundation.org, bp@alien8.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com,
konrad.wilk@oracle.com, elliott@hpe.com
Subject: Re: [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd interfaces to handle large PAT bit
Date: Mon, 09 Nov 2015 17:40:34 -0700 [thread overview]
Message-ID: <1447116034.21443.41.camel@hpe.com> (raw)
In-Reply-To: <1447111134.21443.30.camel@hpe.com>
On Mon, 2015-11-09 at 16:18 -0700, Toshi Kani wrote:
> On Mon, 2015-11-09 at 17:36 -0500, Boris Ostrovsky wrote:
> > On 11/09/2015 03:47 PM, Kirill A. Shutemov wrote:
> > > On Mon, Nov 09, 2015 at 02:39:31PM -0500, Boris Ostrovsky wrote:
> > > > On 11/09/2015 02:16 PM, Toshi Kani wrote:
:
> > > >
> > > > FWIW, it looks like pmd_pfn_mask() inline is causing this. Reverting it
> > > > alone makes this crash go away.
> > > Could you check the patch below?
> >
> >
> > I does fix the problem on baremetal, thanks. My 32-bit Xen guests still
> > fail which I thought was the same issue but now that I looked at it more
> > carefully it has different signature.
>
> I do not think Xen is hitting this, but I think page_level_mask() has the same
> issue for a long time. I will set up 32-bit env on a system with >4GB memory
> to verify this.
As Kirill explained me in his code review comment for *PAGE_MASK, page_level_mas
k() is fine as it is used for virtual addresses.
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-10 0:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 18:24 [PATCH v4 RESEND 0/11] x86/mm: Handle large PAT bit in pud/pmd interfaces Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 1/11] x86/vdso32: Define PGTABLE_LEVELS to 32bit VDSO Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 2/11] x86/asm: Move PUD_PAGE macros to page_types.h Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 3/11] x86/asm: Add pud/pmd mask interfaces to handle large PAT bit Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 4/11] x86/asm: Fix pud/pmd " Toshi Kani
2015-11-09 18:06 ` Boris Ostrovsky
2015-11-09 19:16 ` Toshi Kani
2015-11-09 19:39 ` Boris Ostrovsky
2015-11-09 20:47 ` Kirill A. Shutemov
2015-11-09 22:36 ` Boris Ostrovsky
2015-11-09 23:18 ` Toshi Kani
2015-11-10 0:40 ` Toshi Kani [this message]
2015-11-09 20:10 ` Kirill A. Shutemov
2015-11-09 21:01 ` Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 5/11] x86/asm: Add pud_pgprot() and pmd_pgprot() Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 6/11] x86/mm: Fix page table dump to show PAT bit Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 7/11] x86/mm: Fix slow_virt_to_phys() to handle large " Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 8/11] x86/mm: Fix gup_huge_p?d() " Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 9/11] x86/mm: Fix try_preserve_large_page() " Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 10/11] x86/mm: Fix __split_large_page() " Toshi Kani
2015-09-17 18:24 ` [PATCH v4 RESEND 11/11] x86/mm: Fix no-change case in try_preserve_large_page() Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447116034.21443.41.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kirill@shutemov.name \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox