[PATCH] kasan: always taint kernel on report.

[PATCH] kasan: always taint kernel on report.

[Andrey Ryabinin]

Currently we already taint the kernel in some cases.
E.g. if we hit some bug in slub memory we call object_err()
which will taint the kernel with TAINT_BAD_PAGE flag.
But for other kind of bugs kernel left untainted.

Always taint with TAINT_BAD_PAGE if kasan found some bug.
This is useful for automated testing.

Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 mm/kasan/report.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index f5e068a..12f222d 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -238,6 +238,7 @@ static void kasan_report_error(struct kasan_access_info *info)
 	}
 	pr_err("================================="
 		"=================================\n");
+	add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE);
 	spin_unlock_irqrestore(&report_lock, flags);
 	kasan_enable_current();
 }
-- 
2.4.10

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] kasan: always taint kernel on report.

[Dmitry Vyukov]

Look good to me.

Reviewed-by: Dmitry Vyukov <dvyukov@google.com>


On Wed, Oct 21, 2015 at 6:28 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
> Currently we already taint the kernel in some cases.
> E.g. if we hit some bug in slub memory we call object_err()
> which will taint the kernel with TAINT_BAD_PAGE flag.
> But for other kind of bugs kernel left untainted.
>
> Always taint with TAINT_BAD_PAGE if kasan found some bug.
> This is useful for automated testing.
>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> ---
>  mm/kasan/report.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index f5e068a..12f222d 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -238,6 +238,7 @@ static void kasan_report_error(struct kasan_access_info *info)
>         }
>         pr_err("================================="
>                 "=================================\n");
> +       add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE);
>         spin_unlock_irqrestore(&report_lock, flags);
>         kasan_enable_current();
>  }
> --
> 2.4.10
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>