From: Liao Tonglang <liaotonglang@gmail.com>
To: tj@kernel.org, axboe@fb.com, akpm@linux-foundation.org,
jack@suse.cz, hannes@cmpxchg.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Liao Tonglang <liaotonglang@gmail.com>
Subject: [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized
Date: Mon, 12 Oct 2015 20:24:58 +0800 [thread overview]
Message-ID: <1444652698-28292-1-git-send-email-liaotonglang@gmail.com> (raw)
Variables m_thresh and m_dirty in function balance_dirty_pages() may use
uninitialized. GCC throws a warning on it. Fixed by assigned to 0 as
initial value.
Signed-off-by: Liao Tonglang <liaotonglang@gmail.com>
---
mm/page-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 0a931cd..288db45 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1534,7 +1534,7 @@ static void balance_dirty_pages(struct address_space *mapping,
for (;;) {
unsigned long now = jiffies;
unsigned long dirty, thresh, bg_thresh;
- unsigned long m_dirty, m_thresh, m_bg_thresh;
+ unsigned long m_dirty = 0, m_thresh = 0, m_bg_thresh;
/*
* Unstable writes are a feature of certain networked
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2015-10-12 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 12:24 Liao Tonglang [this message]
2015-10-12 12:58 ` Jan Kara
2015-10-13 1:41 ` Liao Tonglang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444652698-28292-1-git-send-email-liaotonglang@gmail.com \
--to=liaotonglang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox