From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@linux.intel.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <dchinner@redhat.com>, Jan Kara <jack@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-nvdimm@lists.01.org
Subject: [PATCH 0/3] Revert locking changes in DAX for v4.3
Date: Fri, 2 Oct 2015 15:02:29 -0600 [thread overview]
Message-ID: <1443819752-17091-1-git-send-email-ross.zwisler@linux.intel.com> (raw)
This series reverts some recent changes to the locking scheme in DAX introduced
by these two commits:
commit 843172978bb9 ("dax: fix race between simultaneous faults")
commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")
The list of issues in DAX after these commits (some newly introduced by the
commits, some preexisting) can be found here:
https://lkml.org/lkml/2015/9/25/602
Several of these issues were preexisting, and are being addressed by moving the
locking in DAX to the filesystem. A patch series doing this for XFS is here:
https://lkml.org/lkml/2015/10/1/180
These fixes will end up hitting v4.4, hopefully.
In the mean time the above two commits *did* introduce several deadlocks and a
null pointer issue. I started fixing them one at a time:
https://lkml.org/lkml/2015/9/23/607
https://lkml.org/lkml/2015/9/22/668
But it soon became apparent that there were just too many corner cases. The
current plan is to revert the locking in DAX to the old v4.2 scheme, and then
proceed with fixing the rest of the issues by moving the locking into the
various filesystems that support DAX. Dave Chinner is working on this for XFS,
and Jan Kara has said he will help with ext4.
akpm, this series obviates my patch "dax: fix deadlock in __dax_fault()" that
is currently in the -mm tree but which I believe has not yet been sent to Linus.
Can you please just remove it from -mm?
Ross Zwisler (3):
Revert "dax: fix NULL pointer in __dax_pmd_fault()"
Revert "mm: take i_mmap_lock in unmap_mapping_range() for DAX"
Revert "dax: fix race between simultaneous faults"
fs/dax.c | 83 +++++++++++++++++++++++++------------------------------------
mm/memory.c | 2 ++
2 files changed, 36 insertions(+), 49 deletions(-)
--
2.1.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2015-10-02 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 21:02 Ross Zwisler [this message]
2015-10-02 21:02 ` [PATCH 2/3] Revert "mm: take i_mmap_lock in unmap_mapping_range() for DAX" Ross Zwisler
2015-10-02 21:02 ` [PATCH 3/3] Revert "dax: fix race between simultaneous faults" Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443819752-17091-1-git-send-email-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dchinner@redhat.com \
--cc=jack@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox