linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Hugh Dickins <hughd@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>, Mel Gorman <mgorman@suse.de>,
	Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
	Christoph Lameter <cl@gentwo.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Steve Capper <steve.capper@linaro.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Jerome Marchand <jmarchan@redhat.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv11 08/37] khugepaged: ignore pmd tables with THP mapped with ptes
Date: Fri, 18 Sep 2015 18:01:11 +0300	[thread overview]
Message-ID: <1442588500-77331-9-git-send-email-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <1442588500-77331-1-git-send-email-kirill.shutemov@linux.intel.com>

Prepare khugepaged to see compound pages mapped with pte. For now we
won't collapse the pmd table with such pte.

khugepaged is subject for future rework wrt new refcounting.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Tested-by: Sasha Levin <sasha.levin@oracle.com>
Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Acked-by: Jerome Marchand <jmarchan@redhat.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 include/trace/events/huge_memory.h |  1 +
 mm/huge_memory.c                   | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
index 1efc7f1dc9bd..11c59ca5e145 100644
--- a/include/trace/events/huge_memory.h
+++ b/include/trace/events/huge_memory.h
@@ -22,6 +22,7 @@
 	EM( SCAN_PAGE_LRU,		"page_not_in_lru")		\
 	EM( SCAN_PAGE_LOCK,		"page_locked")			\
 	EM( SCAN_PAGE_ANON,		"page_not_anon")		\
+	EM( SCAN_PAGE_COMPOUND,		"page_compound")		\
 	EM( SCAN_ANY_PROCESS,		"no_process_for_page")		\
 	EM( SCAN_VMA_NULL,		"vma_null")			\
 	EM( SCAN_VMA_CHECK,		"vma_check_failed")		\
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 1e87739ceefc..44472136a67f 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -46,6 +46,7 @@ enum scan_result {
 	SCAN_PAGE_LRU,
 	SCAN_PAGE_LOCK,
 	SCAN_PAGE_ANON,
+	SCAN_PAGE_COMPOUND,
 	SCAN_ANY_PROCESS,
 	SCAN_VMA_NULL,
 	SCAN_VMA_CHECK,
@@ -2887,6 +2888,13 @@ static int khugepaged_scan_pmd(struct mm_struct *mm,
 			result = SCAN_PAGE_NULL;
 			goto out_unmap;
 		}
+
+		/* TODO: teach khugepaged to collapse THP mapped with pte */
+		if (PageCompound(page)) {
+			result = SCAN_PAGE_COMPOUND;
+			goto out_unmap;
+		}
+
 		/*
 		 * Record which node the original page is from and save this
 		 * information to khugepaged_node_load[].
@@ -2899,9 +2907,8 @@ static int khugepaged_scan_pmd(struct mm_struct *mm,
 			goto out_unmap;
 		}
 		khugepaged_node_load[node]++;
-		VM_BUG_ON_PAGE(PageCompound(page), page);
 		if (!PageLRU(page)) {
-		result = SCAN_SCAN_ABORT;
+			result = SCAN_SCAN_ABORT;
 			goto out_unmap;
 		}
 		if (PageLocked(page)) {
-- 
2.5.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-09-18 15:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 15:01 [PATCHv11 00/37] THP refcounting redesign Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 01/37] mm, proc: adjust PSS calculation Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 02/37] rmap: add argument to charge compound page Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 03/37] memcg: adjust to support new THP refcounting Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 04/37] mm, thp: adjust conditions when we can reuse the page on WP fault Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 05/37] mm: adjust FOLL_SPLIT for new refcounting Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 06/37] mm: handle PTE-mapped tail pages in gerneric fast gup implementaiton Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 07/37] thp, mlock: do not allow huge pages in mlocked area Kirill A. Shutemov
2015-09-18 15:01 ` Kirill A. Shutemov [this message]
2015-09-18 15:01 ` [PATCHv11 09/37] thp: rename split_huge_page_pmd() to split_huge_pmd() Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 10/37] mm, vmstats: new THP splitting event Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 11/37] mm: temporally mark THP broken Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 12/37] thp: drop all split_huge_page()-related code Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 13/37] mm: drop tail page refcounting Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 14/37] futex, thp: remove special case for THP in get_futex_key Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 15/37] ksm: prepare to new THP semantics Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 16/37] mm, thp: remove compound_lock Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 17/37] arm64, thp: remove infrastructure for handling splitting PMDs Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 18/37] arm, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 19/37] mips, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 20/37] powerpc, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 21/37] s390, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 22/37] sparc, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 23/37] tile, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 24/37] x86, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 25/37] mm, " Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 27/37] mm: differentiate page_mapped() from page_mapcount() for compound pages Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 28/37] mm, numa: skip PTE-mapped THP on numa fault Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 29/37] thp: implement split_huge_pmd() Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 30/37] thp: add option to setup migration entries during PMD split Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 31/37] thp, mm: split_huge_page(): caller need to lock page Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 32/37] thp: reintroduce split_huge_page() Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 33/37] migrate_pages: try to split pages on qeueuing Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 34/37] thp: introduce deferred_split_huge_page() Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 35/37] mm: re-enable THP Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 36/37] thp: update documentation Kirill A. Shutemov
2015-09-18 15:01 ` [PATCHv11 37/37] thp: allow mlocked THP again Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442588500-77331-9-git-send-email-kirill.shutemov@linux.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cl@gentwo.org \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=riel@redhat.com \
    --cc=sasha.levin@oracle.com \
    --cc=steve.capper@linaro.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox