From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f181.google.com (mail-ig0-f181.google.com [209.85.213.181]) by kanga.kvack.org (Postfix) with ESMTP id CEA196B0256 for ; Mon, 24 Aug 2015 18:15:52 -0400 (EDT) Received: by igfj19 with SMTP id j19so72478493igf.0 for ; Mon, 24 Aug 2015 15:15:52 -0700 (PDT) Received: from mail1.windriver.com (mail1.windriver.com. [147.11.146.13]) by mx.google.com with ESMTPS id d11si8502035ioe.133.2015.08.24.15.15.52 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Aug 2015 15:15:52 -0700 (PDT) From: Paul Gortmaker Subject: [PATCH 04/10] mm: make vmscan.c explicitly non-modular Date: Mon, 24 Aug 2015 18:14:36 -0400 Message-ID: <1440454482-12250-5-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> References: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Paul Gortmaker , Michal Hocko , Johannes Weiner , Vladimir Davydov , Mel Gorman The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall() might make more sense. We don't replace module.h with init.h since the file already has that. Cc: Andrew Morton Cc: Michal Hocko Cc: Johannes Weiner Cc: Vladimir Davydov Cc: Mel Gorman Cc: linux-mm@kvack.org Signed-off-by: Paul Gortmaker --- mm/vmscan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 110733a715f6..dd0b58ff3938 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -14,7 +14,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include -#include #include #include #include @@ -3687,8 +3686,7 @@ static int __init kswapd_init(void) hotcpu_notifier(cpu_callback, 0); return 0; } - -module_init(kswapd_init) +device_initcall(kswapd_init) #ifdef CONFIG_NUMA /* -- 2.5.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org