* [PATCH] mm: cma: mark cma_bitmap_maxno() inline in header
@ 2015-08-13 0:01 Gregory Fong
0 siblings, 0 replies; only message in thread
From: Gregory Fong @ 2015-08-13 0:01 UTC (permalink / raw)
To: linux-mm; +Cc: Gregory Fong, Joonsoo Kim, Sasha Levin, Andrew Morton, open list
cma_bitmap_maxno() was marked as static and not static inline, which
can cause warnings about this function not being used if this file is
included in a file that does not call that function, and violates the
conventions used elsewhere. The two options are to move the function
implementation back to mm/cma.c or make it inline here, and it's
simple enough for the latter to make sense.
Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
---
mm/cma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/cma.h b/mm/cma.h
index 1132d73..17c75a4 100644
--- a/mm/cma.h
+++ b/mm/cma.h
@@ -16,7 +16,7 @@ struct cma {
extern struct cma cma_areas[MAX_CMA_AREAS];
extern unsigned cma_area_count;
-static unsigned long cma_bitmap_maxno(struct cma *cma)
+static inline unsigned long cma_bitmap_maxno(struct cma *cma)
{
return cma->count >> cma->order_per_bit;
}
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-13 0:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-13 0:01 [PATCH] mm: cma: mark cma_bitmap_maxno() inline in header Gregory Fong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox