linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	Andres Lagar-Cavilla <andreslc@google.com>,
	Vladimir Davydov <vdavydov@parallels.com>
Subject: [PATCH -next] mm: Fix build breakage seen if MMU_NOTIFIER is not configured
Date: Mon, 27 Jul 2015 08:02:23 -0700	[thread overview]
Message-ID: <1438009343-25468-1-git-send-email-linux@roeck-us.net> (raw)

Commit 65525488fa86 ("proc: add kpageidle file") introduces code
which depends on MMU_NOTIFIER, yet the newly introduced configuration
flag does not declare that dependency. This results in the following
build failures seen if IDLE_PAGE_TRACKING is configured but MMU_NOTIFIER
is not.

fs/proc/page.c: In function 'kpageidle_clear_pte_refs_one':
fs/proc/page.c:341:4: error:
	implicit declaration of function 'pmdp_clear_young_notify'
fs/proc/page.c:347:4: error:
	implicit declaration of function 'ptep_clear_young_notify'

Fixes: 65525488fa86 ("proc: add kpageidle file")
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andres Lagar-Cavilla <andreslc@google.com>
Cc: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 mm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 7e9ccb438985..b73b41c3217b 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -651,6 +651,7 @@ config DEFERRED_STRUCT_PAGE_INIT
 
 config IDLE_PAGE_TRACKING
 	bool "Enable idle page tracking"
+	depends on MMU_NOTIFIER
 	select PROC_PAGE_MONITOR
 	select PAGE_EXTENSION if !64BIT
 	help
-- 
2.1.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2015-07-27 15:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 15:02 Guenter Roeck [this message]
2015-07-27 15:17 ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438009343-25468-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akpm@linux-foundation.org \
    --cc=andreslc@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox