From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shaohua Li <shli@fb.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, Kernel-team@fb.com,
clm@fb.com, linux-mm@kvack.org, dbavatar@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [RFC v2] net: use atomic allocation for order-3 page allocation
Date: Thu, 11 Jun 2015 16:38:22 -0700 [thread overview]
Message-ID: <1434065902.27504.64.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20150611233235.GA667489@devbig257.prn2.facebook.com>
On Thu, 2015-06-11 at 16:32 -0700, Shaohua Li wrote:
>
> Ok, looks similar, added. Didn't trigger this one though.
Probably because you do not use af_unix with big enough messages.
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 3cfff2a..9856c7a 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -4398,7 +4398,9 @@ struct sk_buff *alloc_skb_with_frags(unsigned long header_len,
>
> while (order) {
> if (npages >= 1 << order) {
> - page = alloc_pages(gfp_mask |
Here, order is > 0 (Look at while (order) right above)
> + gfp_t gfp = order > 0 ?
> + gfp_mask & ~__GFP_WAIT : gfp_mask;
> + page = alloc_pages(gfp |
> __GFP_COMP |
> __GFP_NOWARN |
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-11 23:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 22:27 Shaohua Li
2015-06-11 20:48 ` [RFC] " Eric Dumazet
2015-06-11 21:16 ` Chris Mason
2015-06-11 21:22 ` Eric Dumazet
2015-06-11 21:45 ` Shaohua Li
2015-06-11 21:56 ` Eric Dumazet
2015-06-11 22:01 ` Shaohua Li
2015-06-11 22:18 ` Chris Mason
2015-06-11 22:55 ` Eric Dumazet
2015-06-11 21:35 ` Debabrata Banerjee
2015-06-11 22:18 ` David Miller
2015-06-12 9:25 ` Vlastimil Babka
2015-06-11 21:25 ` Debabrata Banerjee
2015-06-11 21:28 ` Debabrata Banerjee
2015-06-12 9:34 ` Vlastimil Babka
2015-06-11 22:53 ` [RFC v2] " Eric Dumazet
2015-06-11 23:32 ` Shaohua Li
2015-06-11 23:38 ` Eric Dumazet [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-11 22:27 Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434065902.27504.64.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dbavatar@gmail.com \
--cc=edumazet@google.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox