* [GIT PULL 00/25] perf/core improvements and fixes
@ 2015-05-05 21:31 Arnaldo Carvalho de Melo
2015-05-05 21:32 ` [PATCH 14/25] perf kmem: Show warning when trying to run stat without record Arnaldo Carvalho de Melo
2015-05-06 2:47 ` [GIT PULL 00/25] perf/core improvements and fixes Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-05-05 21:31 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Joonsoo Kim,
linux-mm, Masami Hiramatsu, Minchan Kim, Namhyung Kim,
Pekka Enberg, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider applying, on top of previous requests,
- Arnaldo
The following changes since commit 0c160d495b5616e071bb4f873812e8f473128149:
perf kmem: Add kmem.default config option (2015-05-04 13:34:48 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-3
for you to fetch changes up to 3698dab1c849c7e1cd440df4fca24baa1973d53b:
perf tools: Move TUI-specific fields out of map_symbol (2015-05-05 18:13:24 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Improve --filter support for 'perf probe', allowing using its arguments
on other commands, as --add, --del, etc (Masami Hiramatsu)
- Show warning when running 'perf kmem stat' on a unsuitable perf.data file,
i.e. one with events that are not the ones required for the stat variant
used (Namhyung Kim).
Infrastructure:
- Auxtrace support patches, paving the way to support Intel PT and BTS (Adrian Hunter)
- hists browser (top, report) refactorings (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (9):
perf report: Fix placement of itrace option in documentation
perf tools: Add AUX area tracing index
perf tools: Hit all build ids when AUX area tracing
perf tools: Add build option NO_AUXTRACE to exclude AUX area tracing
perf auxtrace: Add option to synthesize events for transactions
perf tools: Add support for PERF_RECORD_AUX
perf tools: Add support for PERF_RECORD_ITRACE_START
perf tools: Add AUX area tracing Snapshot Mode
perf record: Add AUX area tracing Snapshot Mode support
Masami Hiramatsu (4):
perf probe: Allow to use filter on --del command
perf probe: Accept filter argument for --funcs
perf probe: Remove redundant cleanup of params.filter
perf probe: Cleanup and consolidate command parsers
Namhyung Kim (12):
perf kmem: Show warning when trying to run stat without record
perf tools: Move TUI-specific fields into unnamed union
perf tools: Move init_have_children field to the unnamed union
perf hists browser: Fix possible memory leak
perf hists browser: Save hist_browser_timer pointer in hist_browser
perf hists browser: Save pstack in the hist_browser
perf hists browser: Save perf_session_env in the hist_browser
perf hists browser: Split popup menu actions
perf hists browser: Split popup menu actions - part 2
perf tools: Introduce pstack_peek()
perf hists browser: Simplify zooming code using pstack_peek()
perf tools: Move TUI-specific fields out of map_symbol
tools/perf/Documentation/perf-inject.txt | 9 +-
tools/perf/Documentation/perf-probe.txt | 3 +-
tools/perf/Documentation/perf-record.txt | 7 +
tools/perf/Documentation/perf-report.txt | 15 +-
tools/perf/Documentation/perf-script.txt | 9 +-
tools/perf/Makefile.perf | 2 +
tools/perf/builtin-buildid-list.c | 9 +
tools/perf/builtin-inject.c | 78 +++-
tools/perf/builtin-kmem.c | 17 +-
tools/perf/builtin-probe.c | 133 +++----
tools/perf/builtin-record.c | 172 ++++++++-
tools/perf/config/Makefile | 5 +
tools/perf/perf.h | 3 +
tools/perf/tests/make | 4 +-
tools/perf/ui/browsers/hists.c | 633 +++++++++++++++++++------------
tools/perf/util/Build | 2 +-
tools/perf/util/auxtrace.c | 305 ++++++++++++++-
tools/perf/util/auxtrace.h | 217 +++++++++++
tools/perf/util/callchain.h | 4 +
tools/perf/util/event.c | 39 ++
tools/perf/util/event.h | 24 ++
tools/perf/util/header.c | 31 +-
tools/perf/util/hist.c | 2 +-
tools/perf/util/machine.c | 21 +
tools/perf/util/machine.h | 4 +
tools/perf/util/parse-options.h | 4 +
tools/perf/util/probe-event.c | 102 ++---
tools/perf/util/probe-event.h | 2 +-
tools/perf/util/pstack.c | 7 +
tools/perf/util/pstack.h | 1 +
tools/perf/util/session.c | 32 ++
tools/perf/util/session.h | 1 +
tools/perf/util/sort.h | 22 +-
tools/perf/util/symbol.h | 2 -
tools/perf/util/tool.h | 2 +
35 files changed, 1455 insertions(+), 468 deletions(-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 14/25] perf kmem: Show warning when trying to run stat without record
2015-05-05 21:31 [GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2015-05-05 21:32 ` Arnaldo Carvalho de Melo
2015-05-06 2:47 ` [GIT PULL 00/25] perf/core improvements and fixes Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-05-05 21:32 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa, Joonsoo Kim,
Minchan Kim, Peter Zijlstra, linux-mm, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
Sometimes one can mistakenly run 'perf kmem stat' without running 'perf
kmem record' before or with a different configuration like recording
--slab and stat --page. Show a warning message like the one below to
inform the user:
# perf kmem stat --page --caller
No page allocation events found. Have you run 'perf kmem record --page'?
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Pekka Enberg <penberg@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Joonsoo Kim <js1304@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/1430837572-31395-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-kmem.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index 828b728..e628bf1 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -1882,6 +1882,7 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
};
struct perf_session *session;
int ret = -1;
+ const char errmsg[] = "No %s allocation events found. Have you run 'perf kmem record --%s'?\n";
perf_config(kmem_config, NULL);
argc = parse_options_subcommand(argc, argv, kmem_options,
@@ -1908,11 +1909,21 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
if (session == NULL)
return -1;
+ if (kmem_slab) {
+ if (!perf_evlist__find_tracepoint_by_name(session->evlist,
+ "kmem:kmalloc")) {
+ pr_err(errmsg, "slab", "slab");
+ return -1;
+ }
+ }
+
if (kmem_page) {
- struct perf_evsel *evsel = perf_evlist__first(session->evlist);
+ struct perf_evsel *evsel;
- if (evsel == NULL || evsel->tp_format == NULL) {
- pr_err("invalid event found.. aborting\n");
+ evsel = perf_evlist__find_tracepoint_by_name(session->evlist,
+ "kmem:mm_page_alloc");
+ if (evsel == NULL) {
+ pr_err(errmsg, "page", "page");
return -1;
}
--
2.1.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [GIT PULL 00/25] perf/core improvements and fixes
2015-05-05 21:31 [GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-05-05 21:32 ` [PATCH 14/25] perf kmem: Show warning when trying to run stat without record Arnaldo Carvalho de Melo
@ 2015-05-06 2:47 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2015-05-06 2:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, David Ahern, Frederic Weisbecker,
Jiri Olsa, Joonsoo Kim, linux-mm, Masami Hiramatsu, Minchan Kim,
Namhyung Kim, Pekka Enberg, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider applying, on top of previous requests,
>
> - Arnaldo
>
> The following changes since commit 0c160d495b5616e071bb4f873812e8f473128149:
>
> perf kmem: Add kmem.default config option (2015-05-04 13:34:48 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-3
>
> for you to fetch changes up to 3698dab1c849c7e1cd440df4fca24baa1973d53b:
>
> perf tools: Move TUI-specific fields out of map_symbol (2015-05-05 18:13:24 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Improve --filter support for 'perf probe', allowing using its arguments
> on other commands, as --add, --del, etc (Masami Hiramatsu)
>
> - Show warning when running 'perf kmem stat' on a unsuitable perf.data file,
> i.e. one with events that are not the ones required for the stat variant
> used (Namhyung Kim).
>
> Infrastructure:
>
> - Auxtrace support patches, paving the way to support Intel PT and BTS (Adrian Hunter)
>
> - hists browser (top, report) refactorings (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (9):
> perf report: Fix placement of itrace option in documentation
> perf tools: Add AUX area tracing index
> perf tools: Hit all build ids when AUX area tracing
> perf tools: Add build option NO_AUXTRACE to exclude AUX area tracing
> perf auxtrace: Add option to synthesize events for transactions
> perf tools: Add support for PERF_RECORD_AUX
> perf tools: Add support for PERF_RECORD_ITRACE_START
> perf tools: Add AUX area tracing Snapshot Mode
> perf record: Add AUX area tracing Snapshot Mode support
>
> Masami Hiramatsu (4):
> perf probe: Allow to use filter on --del command
> perf probe: Accept filter argument for --funcs
> perf probe: Remove redundant cleanup of params.filter
> perf probe: Cleanup and consolidate command parsers
>
> Namhyung Kim (12):
> perf kmem: Show warning when trying to run stat without record
> perf tools: Move TUI-specific fields into unnamed union
> perf tools: Move init_have_children field to the unnamed union
> perf hists browser: Fix possible memory leak
> perf hists browser: Save hist_browser_timer pointer in hist_browser
> perf hists browser: Save pstack in the hist_browser
> perf hists browser: Save perf_session_env in the hist_browser
> perf hists browser: Split popup menu actions
> perf hists browser: Split popup menu actions - part 2
> perf tools: Introduce pstack_peek()
> perf hists browser: Simplify zooming code using pstack_peek()
> perf tools: Move TUI-specific fields out of map_symbol
>
> tools/perf/Documentation/perf-inject.txt | 9 +-
> tools/perf/Documentation/perf-probe.txt | 3 +-
> tools/perf/Documentation/perf-record.txt | 7 +
> tools/perf/Documentation/perf-report.txt | 15 +-
> tools/perf/Documentation/perf-script.txt | 9 +-
> tools/perf/Makefile.perf | 2 +
> tools/perf/builtin-buildid-list.c | 9 +
> tools/perf/builtin-inject.c | 78 +++-
> tools/perf/builtin-kmem.c | 17 +-
> tools/perf/builtin-probe.c | 133 +++----
> tools/perf/builtin-record.c | 172 ++++++++-
> tools/perf/config/Makefile | 5 +
> tools/perf/perf.h | 3 +
> tools/perf/tests/make | 4 +-
> tools/perf/ui/browsers/hists.c | 633 +++++++++++++++++++------------
> tools/perf/util/Build | 2 +-
> tools/perf/util/auxtrace.c | 305 ++++++++++++++-
> tools/perf/util/auxtrace.h | 217 +++++++++++
> tools/perf/util/callchain.h | 4 +
> tools/perf/util/event.c | 39 ++
> tools/perf/util/event.h | 24 ++
> tools/perf/util/header.c | 31 +-
> tools/perf/util/hist.c | 2 +-
> tools/perf/util/machine.c | 21 +
> tools/perf/util/machine.h | 4 +
> tools/perf/util/parse-options.h | 4 +
> tools/perf/util/probe-event.c | 102 ++---
> tools/perf/util/probe-event.h | 2 +-
> tools/perf/util/pstack.c | 7 +
> tools/perf/util/pstack.h | 1 +
> tools/perf/util/session.c | 32 ++
> tools/perf/util/session.h | 1 +
> tools/perf/util/sort.h | 22 +-
> tools/perf/util/symbol.h | 2 -
> tools/perf/util/tool.h | 2 +
> 35 files changed, 1455 insertions(+), 468 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-06 2:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-05 21:31 [GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-05-05 21:32 ` [PATCH 14/25] perf kmem: Show warning when trying to run stat without record Arnaldo Carvalho de Melo
2015-05-06 2:47 ` [GIT PULL 00/25] perf/core improvements and fixes Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox