From: Michal Hocko <mhocko@suse.cz>
To: linux-mm@kvack.org
Cc: Cyril Hrubis <chrubis@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Michel Lespinasse <walken@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: Should mmap MAP_LOCKED fail if mm_poppulate fails?
Date: Tue, 28 Apr 2015 14:11:48 +0200 [thread overview]
Message-ID: <1430223111-14817-1-git-send-email-mhocko@suse.cz> (raw)
In-Reply-To: <20150114095019.GC4706@dhcp22.suse.cz>
Hi,
it seems that the initial email got lost (or ignored). I would like to
revive it again. I've cooked up a potential fix to this issue which will
follow as a reply to this email.
The first patch is dumb and straightforward. It should be safe as is and
also good without the follow up 2 patches which try to handle potential
allocation failures in the do_munmap path more gracefully. As we still
do not fail small allocations even the first patch could be simplified
a bit and the retry loop replaced by a BUG_ON right away. But I felt this
would better be done robust.
An obvious alternative would be patching the man pages to mention the
subtle difference between mlock and MAP_LOCKED semantic. I have checked
debian code search and it shown some applications relying on MAP_LOCKED
but I have no idea whether they really require the mlock all-or-nothing
fault in semantic.
Any thoughts, ideas?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-28 12:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 9:50 Michal Hocko
2015-04-28 12:11 ` Michal Hocko [this message]
2015-04-28 12:11 ` [RFC 1/3] mm: mmap make MAP_LOCKED really mlock semantic Michal Hocko
2015-04-28 23:10 ` Andrew Morton
2015-04-29 7:52 ` Michal Hocko
2015-04-28 12:11 ` [RFC 2/3] mm: allow munmap related functions to understand gfp_mask Michal Hocko
2015-04-28 12:11 ` [RFC 3/3] mm: introduce do_munmap_nofail Michal Hocko
2015-04-28 16:01 ` Should mmap MAP_LOCKED fail if mm_poppulate fails? Linus Torvalds
2015-04-28 16:43 ` Michal Hocko
2015-04-28 16:57 ` Linus Torvalds
2015-04-28 18:35 ` Michal Hocko
2015-04-28 18:38 ` Linus Torvalds
2015-04-28 20:36 ` Michal Hocko
2015-04-29 11:38 ` [RFC PATCH] mmap.2: clarify MAP_LOCKED semantic (was: Re: Should mmap MAP_LOCKED fail if mm_poppulate fails?) Michal Hocko
2015-04-30 0:28 ` David Rientjes
2015-04-30 14:52 ` Michal Hocko
2015-05-06 12:21 ` Michal Hocko
2015-04-28 20:21 ` Should mmap MAP_LOCKED fail if mm_poppulate fails? Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430223111-14817-1-git-send-email-mhocko@suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=chrubis@suse.cz \
--cc=hughd@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtk.manpages@gmail.com \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox