linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: fixed whitespace style errors in failslab.c
@ 2015-04-27  7:33 Derek Robson
  2015-04-27  7:44 ` Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Derek Robson @ 2015-04-27  7:33 UTC (permalink / raw)
  To: linux-mm, linux-kernel; +Cc: Derek Robson

This patch fixes a white space issue found with checkpatch.pl in failslab.c
ERROR: code indent should use tabs where possible

Added a tab to replace the spaces to meet the preferred style.

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 mm/failslab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/failslab.c b/mm/failslab.c
index fefaaba..2064225 100644
--- a/mm/failslab.c
+++ b/mm/failslab.c
@@ -16,7 +16,7 @@ bool should_failslab(size_t size, gfp_t gfpflags, unsigned long cache_flags)
 	if (gfpflags & __GFP_NOFAIL)
 		return false;
 
-        if (failslab.ignore_gfp_wait && (gfpflags & __GFP_WAIT))
+	if (failslab.ignore_gfp_wait && (gfpflags & __GFP_WAIT))
 		return false;
 
 	if (failslab.cache_filter && !(cache_flags & SLAB_FAILSLAB))
-- 
2.3.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: fixed whitespace style errors in failslab.c
  2015-04-27  7:33 [PATCH] mm: fixed whitespace style errors in failslab.c Derek Robson
@ 2015-04-27  7:44 ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2015-04-27  7:44 UTC (permalink / raw)
  To: Derek Robson; +Cc: linux-mm, LKML

On Mon, Apr 27, 2015 at 9:33 AM, Derek Robson <robsonde@gmail.com> wrote:
> This patch fixes a white space issue found with checkpatch.pl in failslab.c
> ERROR: code indent should use tabs where possible
>
> Added a tab to replace the spaces to meet the preferred style.
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  mm/failslab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Running checkpatch.pl against in-tree files is not really useful.
Especially if you "fix" only whitespace stuff.
Most maintainers agree that it is not worth the maintenance overhead
and the git history pollution.

Please stick to drivers/staging/ or fix real issues. :-)

-- 
Thanks,
//richard

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-27  7:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-27  7:33 [PATCH] mm: fixed whitespace style errors in failslab.c Derek Robson
2015-04-27  7:44 ` Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox