From: "Stephen C. Tweedie" <sct@redhat.com>
To: "Benjamin C.R. LaHaise" <blah@kvack.org>
Cc: Rik van Riel <riel@humbolt.geo.uu.nl>,
Linux MM <linux-mm@kvack.org>,
alan@redhat.com
Subject: Re: [2.2.12 PATCH] Re: bdflush defaults bugreport
Date: Mon, 13 Sep 1999 19:06:42 +0100 (BST) [thread overview]
Message-ID: <14301.15666.461081.663416@dukat.scot.redhat.com> (raw)
In-Reply-To: <Pine.LNX.3.96.990905043424.27200B-100000@mole.spellcast.com>
Hi,
On Sun, 5 Sep 1999 04:55:41 -0400 (EDT), "Benjamin C.R. LaHaise"
<blah@kvack.org> said:
> I don't quite think that changing the percentage dirty is the right thing
> in this case. Rather, the semantics of refile_buffer / wakeup_bdflush /
> mark_buffer_clean need to be tweaked: as it stands, bdflush will wake
> bdflush_done before the percentage of dirty buffers drops below the
> threshhold. The right fix should be to move the wake_up into the if
> checking the threshhold right below it as the only user of bdflush_done is
> from wake_bdflush when too many buffers are dirty. Patch below (albeit
> untested). Alan/Stephen: comments?
It shouldn't have any noticeable effect: all that would happen with that
patch applied is that the woken process would wake early, write one more
buffer and drop straight back into the wakeup_bdflush(1) stall.
--Stephen
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
next prev parent reply other threads:[~1999-09-13 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-05 7:58 Rik van Riel
1999-09-05 8:55 ` [2.2.12 PATCH] " Benjamin C.R. LaHaise
1999-09-13 18:06 ` Stephen C. Tweedie [this message]
1999-09-13 18:02 ` Stephen C. Tweedie
[not found] ` <Pine.LNX.3.96.990913140636.29128A-100000@kanga.kvack.org>
1999-09-13 20:24 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14301.15666.461081.663416@dukat.scot.redhat.com \
--to=sct@redhat.com \
--cc=alan@redhat.com \
--cc=blah@kvack.org \
--cc=linux-mm@kvack.org \
--cc=riel@humbolt.geo.uu.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox