linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Stephen C. Tweedie" <sct@redhat.com>
To: Gilles Pokam <pokam@cs.tu-berlin.de>
Cc: "Stephen C. Tweedie" <sct@redhat.com>, linux-mm@kvack.org
Subject: Re: question on remap_page_range()
Date: Tue, 31 Aug 1999 11:58:14 +0100 (BST)	[thread overview]
Message-ID: <14283.46406.589808.626933@dukat.scot.redhat.com> (raw)
In-Reply-To: <Pine.SOL.4.10.9908311000590.16664-100000@elf>

Hi,

On Tue, 31 Aug 1999 10:23:37 +0200 (MET DST), Gilles Pokam
<pokam@cs.tu-berlin.de> said:

>> No.  Either Rubini is wrong or you have misinterpreted.  A physical
>> address is just that --- the physical address of the memory as it
>> appears on the cpu bus when the cpu goes to read from ram.  It is
>> completely untranslated.  The first physical address in the system is
>> usually zero, not PAGE_OFFSET.  

> Sorry, i forget to said "from the kernel point of vue" :

> Rubini's book, page 274 about PAGE_OFFSET:

> " (...) PAGE_OFFSET must be considered whenever "physical" addresses are
> used. What the kernel considers to be a physical address is actually a
> virtual address, offset by PAGE_OFFSET from the real physical
> address.(..)"

That is wrong.  A physical address is a physical address is a physical
address.  Even from the kernel's point of view.  We need to know
physical addresses when we are setting up page tables, for example, and
these do NOT have a PAGE_OFFSET applied.  Ever.

However, the kernel cannot directly access the contents of a physical
address in memory: all memory accesses, without exception, go through
virtual address translation, and _that_ is where PAGE_OFFSET comes in.

Physical addresses do not, ever, include the PAGE_OFFSET bias.

It would be true to say that "What the kernel uses to *access* a
physicall address is actually a virtual address, offset by PAGE_OFFSET
from the real physical addres."  However, the kernel still calls that
latter, offset address a virtual address, not a physical address.  It's
a kernel virtual address as opposed to a user virtual address, but it is
still virtual, not physical.

> About remap_page_range Rubini said: (page 280-281)
> " remap_page_range(unsigned long virt_addr,unsigned long phys_add,
> 	          unsigned log size,pgprot_t prot);
>  unsigned long phys_add:
>     The phyical address to which the virtual address should be mapped. The
>     address is physical in the sense outline above" (in PAGE_OFFSET)

That is nonsense, the physaddr in remap_page_range does not include
PAGE_OFFSET bias.  It makes no sense at all for it to do so.

> To map to user space a region of memory beginning at physical address
> simple_region_start with size = simple_region_size he used the following
> example:
> unsigned long physical = simple_region_start + off + PAGE_OFFSET

That will work on 2.0, but only because PAGE_OFFSET is zero.  It won't
work on 2.2.

--Stephen
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/

      reply	other threads:[~1999-08-31 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-08-28 10:03 Gilles Pokam
1999-08-29 15:18 ` Stephen C. Tweedie
1999-08-31  8:23   ` Gilles Pokam
1999-08-31 10:58     ` Stephen C. Tweedie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14283.46406.589808.626933@dukat.scot.redhat.com \
    --to=sct@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=pokam@cs.tu-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox