From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C0DC35FF3 for ; Fri, 21 Mar 2025 05:35:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 313C0280003; Fri, 21 Mar 2025 01:35:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C1AC280001; Fri, 21 Mar 2025 01:35:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18CA8280003; Fri, 21 Mar 2025 01:35:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF2FC280001 for ; Fri, 21 Mar 2025 01:35:06 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7593E141F72 for ; Fri, 21 Mar 2025 05:35:08 +0000 (UTC) X-FDA: 83244444696.08.D50253B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 05B13A0003 for ; Fri, 21 Mar 2025 05:35:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KZhj/mRC"; spf=pass (imf15.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742535306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QMjAUNZ4CwTQAOy+D76GwsLMdMyaRCTmvcyaAxjE49I=; b=xwefhwio47KR30pi4En4A4vOZ1QB11rRKGLnIjWJCbhre2MnbozXSYYNiC9Fwh31PWyQar JXfewOF7oB04jmTKRYKrWR7Td0k3TqGo79ZPiI3CnjRDmf5RSXTb1DGuDiCJ4vU0+UmySp Wpv6suuHpYYjsF9cgxEgf2VJgbaIUXQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KZhj/mRC"; spf=pass (imf15.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742535306; a=rsa-sha256; cv=none; b=wYj84itxfdXF5FxxxmomcdJgcvdXAc+wq43Kf6IEVP5SvdlBwwpXaa6xl+gmCwVAap6wjs EpI6Tb/22w5geK7ELzDxcT9VxacrMUklaaU3O6EGQ/mcZgmaIMXypIOx2h4QvFSoVGlfys cbx+uVrSopByWPkIr+a5oU0Znmu8TGA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742535305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QMjAUNZ4CwTQAOy+D76GwsLMdMyaRCTmvcyaAxjE49I=; b=KZhj/mRCIPDYTyneo97fQFevX/zeERqbNmFOY7QXuIfEwqat7h4dKgYXdRa+sDdxPuwaBR sGX/+i80GH01GVj6Di5H7Kj0nWFbQlCEC6shDaQQHFesNokrwBCY2W1lp5ErVUbObSvE85 WGV6ILRFqEcwt7bgHBQwgN2DJMN0OVU= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-8c2Js8XTOryGdn-jn6VBmA-1; Fri, 21 Mar 2025 01:35:04 -0400 X-MC-Unique: 8c2Js8XTOryGdn-jn6VBmA-1 X-Mimecast-MFC-AGG-ID: 8c2Js8XTOryGdn-jn6VBmA_1742535303 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-22410b910b0so18605235ad.2 for ; Thu, 20 Mar 2025 22:35:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742535302; x=1743140102; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QMjAUNZ4CwTQAOy+D76GwsLMdMyaRCTmvcyaAxjE49I=; b=RHmxeNJlPlPCsMqFCNpNzSAD5vvuxXFr5boKc4NQOTcLi1hyCARIGG10LwPxgNpPWD Bf91Tcgl0n10K0vhE6yJX4ctCNXyxXGO3A+MWE1ZqsD+DK0FeZ3FKa/nFLdHp2HQ7hiE 3PMexWqXk6TQGjSIsqs4lPmYiLh/XqqrhXvwqgPfANdgeEGsU2/4OqgvMxXihqnzb/qL Pts07jAON4fexJXnQUYKxC/JZKq/EOV/plY0mO1jGDVWv2iO/2iQ73C+lSLgCGhFfPwN xTsdcinvq/JKM4cFPJpZqYw/l+3aGdYMMwYfXIU94yavapPidD0aQXLsh5jmG5A/po49 hJoQ== X-Gm-Message-State: AOJu0YwrnMc+iQf2a3SzNDkg0BUJ0kBb7Q/b5aQz9eT1ZVq7GS32rKoC sB9ohnB+cV9lAhJnn9ofZjQ2k+ghaSQdoF4qjwgWcCrHEyoZn1uOAr4AMkC7tmp14usTZRKrMrd rUm3gCU+z/C0JVv2qWu0wF9qHzdgQO7XcXCL9ol4vNy9hgtmvVoSZEIonVnq6TN6YzgT3MSnaHW YDTkmWFMf+GDsGD31L4jjBETz/dq2N X-Gm-Gg: ASbGncsw98/SBC6KYH/jCirBxr57qWSMLqO8dBjIW4AsT2TIn4OCD/V07vclyC2qIzE l+SlJITVMLNO52H1YnqFjOOlL+klAbMiuLeFhI/s1Z7/O9uHSV2xKNJ08eCRk4ekXuqARUaxKKT RfLwsFBzAXT0zYElV/yp+KPbS5oia5xawb75p436ppSwCsVAjBd6I4gO6BFA2zEhX8SVmxuHxpY ooujc7rC67ts1a5spKshxMTB1dsk6fMQ3vz6KSIq3ZePFzsZgWz2q6Xo6h2fCJ1PKIgHG9CH5HY LeHJpXU2rgopIpOLSw== X-Received: by 2002:a17:902:9042:b0:220:fe51:1aab with SMTP id d9443c01a7336-22780e3fcdcmr30779975ad.38.1742535302288; Thu, 20 Mar 2025 22:35:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+5TFY5QIybOCFPYbufZRYyuUOXtI2NZTA5/SN98eAr4pap9KU24UkSVHZM8SKIV+dQ4A53Q== X-Received: by 2002:a17:902:9042:b0:220:fe51:1aab with SMTP id d9443c01a7336-22780e3fcdcmr30779675ad.38.1742535301908; Thu, 20 Mar 2025 22:35:01 -0700 (PDT) Received: from [192.168.68.55] ([180.233.125.167]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22780f3bbf8sm7927415ad.23.2025.03.20.22.34.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Mar 2025 22:35:00 -0700 (PDT) Message-ID: <141f7331-43fd-4bf4-88ca-36c18b02b133@redhat.com> Date: Fri, 21 Mar 2025 15:34:55 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] Fix parameter passed to page_mapcount_is_type() From: Gavin Shan To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, david@redhat.com, vbabka@suse.cz, osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321053148.1434076-1-gshan@redhat.com> In-Reply-To: <20250321053148.1434076-1-gshan@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hRZpVIPw5EhIVkjveUblZso6HybTFvvEwjsgAdGj7e8_1742535303 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 05B13A0003 X-Stat-Signature: 1s9hpttgke8cagggn3hghniqhyfps1pm X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742535305-414233 X-HE-Meta: U2FsdGVkX19hPIqYIOwcihTk+KnQLFwwOIi/HzBZnmgXi5R50DYcSjPvRsdzVBbB50+72+Bd9twsV1ovkyHihnBc1yQElq8HZr/LgMsVrOpA1f2tAGXlLvG7Ic/pmO3IbH/6IW17DWO2Y34YR3tEcUTyeXR4F5YIg9MEbCnNeSJ8fMQhpfwwUa019IUwAps0rrhV7lEw3SUmL8gwTCmIvyepKe0koej12MNOfTAZfuRTbKkfH/IiMKHFzApvqfcL4uGXQXxrFTwmrvqs8C+VOv24fqUa7OUBbA/1XSJPejoLRHf4pfo0o2GNYRd0aKqSe/N1Tz8dfQoADHq6pIjCLQAIgbEA4DsAwiI2PAe8qMO35Zkxhs6yiEeHsUuUVx0Xy/PMR1PPjyudmutxa5n2+iIO5yPXISDCVFGAcucwfhRbRzA5FjwqW3xfPFgsXImNZXPOTvGh5q/DSJ7nkPOnYdzUsuyg20epuJFup2JhTkM/JFjcWnUn5bpE+fTCtY8JWauxHZrEGoN7cJDhM2ipxeJnhxImuJDfpx9ptI342EouQUanZFTofsgOOFXy5165HrtsUCLmqUw0CmcO9oHOECT+rZI5iHsvXrGMa+eOFDDgD9nf47QLBBoMBgnlnPOlmyF0Ui2tqAgn+tK2oRiCw8UH9Yf5KhM+vZ+e1w+UtHr+B6cEWL7qvrRtWk/yLyjLQ4VpkwnVjgazLnmSZYE70gInYI0BvOOsvfmynqnVZI25tkUATsE8J/AfYaw0afB2HD5Eh1OmSfGBRfA6u6XmvDegyVj0Hw5+KrA9W36QPoZxw0Vso194rpnRzXPysj8w0JtclkX625EyW2OZPtIYX+xD21Sr0KFN+3GGrFQvhqpwrrA0hffp+r4fY9NX+vNgnt85nMWcyIIR2LpNEIiWSBlmEWwt+DYWRgKuyZM7FuKEm4Ihn8sILPJs7jGfmw+ZfX1cKFc9s7RJTmqhFQM qkmiyq/6 oXFiCo5BwsCF6ds4tTcwjB0YgECoA7yv/Mpmk7nRzA/SNq5iwyK8ekHVZWGn+/+M2llhqVDMYUzVFgK3CbP5K1KtbnFWuUhSi9LDxns4DMqRWOdRWDYsHINd15stHNH7ndC6dS7GFVvVgl7dSct43gS1Yvgz2fj4pVZs+dEPGIi4E5sUDPCtIuf4CkbOfBalWqk7mgy/PIiD5LojYOVFIX54HFTe6fPGNN+8lsN+7UCzpq5lLca94dFtdTdEgFR3Qp/QW4jAw6pGYiU/TQDjJqO5OxY5LYyCeu2RyuXAYKM4MxYV922pNM2PEMMFwFWWYCsWEQ/7DnQM9uWZAFFWiZ9c9pd1HIkVxLrV5gOajxeXl/1eNWSzyzvdq22ja9YCXXnc9cJFXFOYmbY5QIt2U0HdQ9VyICABe/hsd5crq+POLhN9p90fA5ZvNVcJbnuxIhTt+P5KXPe7gKwemImvnMo+0p3vQydXaB0ooI1ujh3VMGLw+qai5UOwVWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/25 3:31 PM, Gavin Shan wrote: > Found by code inspection. There are two places where the parameter > passed to page_mapcount_is_type() is (page->__mapcount), which is > correct since it should be one more than the value, as explained in ^^^^^^^ s/correct/incorrect > the comments to page_mapcount_is_type(): (a) page_has_type() in > page-flags.h (b) __dump_folio() in mm/debug.c > > PATCH[1] fixes the parameter for (a) > PATCH[2] fixes the parameter for (b) > > Gavin Shan (2): > mm: Fix parameter passed to page_mapcount_is_type() > mm/debug: Fix parameter passed to page_mapcount_is_type() > > include/linux/page-flags.h | 2 +- > mm/debug.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >