From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ECE5C761AF for ; Thu, 23 Mar 2023 13:49:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DEA46B0072; Thu, 23 Mar 2023 09:49:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68EC66B0074; Thu, 23 Mar 2023 09:49:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52F056B0075; Thu, 23 Mar 2023 09:49:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F7CB6B0072 for ; Thu, 23 Mar 2023 09:49:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 080AB406F4 for ; Thu, 23 Mar 2023 13:49:46 +0000 (UTC) X-FDA: 80600295972.20.A02812C Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 7DA8640012 for ; Thu, 23 Mar 2023 13:49:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DuMvVWGt; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679579384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v68xzKQ9b4gJNFJNPySvveKVr3Exd3D3ITI9n6d+e8w=; b=F8ZkklnjT+fp6SW//iN3q8cgj4UP97BVsYLXTaB40KrPAmBgH0/CvsM9xK0PG5cyYZ0hni SyZhIjI8URbW4vcSC7uGjFGp0R6NzNDHZUlXfK8gNNQHFLtz8LcCifw8RmsA2gieMcuujg Q5OGSW+n7tgsmn1gJjxU0mXHEpglmqg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DuMvVWGt; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679579384; a=rsa-sha256; cv=none; b=F9Pp+n0a9E5WhGlGnIhSdMnOCJNXbOEft/w/irofgwOd8Jmg1I/+xZVFwnzH5yxieim6Zx VsnYNmfaehGGRZU6gi1ryvYith+ETPlbAjUsDzHI05YF+e+ZjWyOz1+uE1CdvZAeOyMnex cvothnJ0/a59YsbcZlz+hTP8PdArmp4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679579383; x=1711115383; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GKZ5Q6PC9RVV67Um5+ppCnF8L4AO5uGcX7XeCD3ye9c=; b=DuMvVWGtJ/I+nAhr84VwUgQjcayYqimHR1nMSmRRQjtj6b1M36b/rKIY sNDFbG/DntOc/OplECkNr6+icborXz6RB9qQ2dzpg7rTghek5udgU2LZ1 PrZUqOA4Ifef6sZblQ1qiP2xFZxpMWZEhmtYVVeUDqsIRnMwpIk9UzCpm 5YMK+DIoz3m+nmBgqBZWjlf5f4vsiyNA+TEoqKpqR2jCveAfjpk4QSVXy 4dqrDU1LtkZE6N1qtaVHI0nJdno7ogUy3eDjRu2ggDAbNW+W3KOXsCunp GxskuLzdgoQnDRQNsK2OuiKre+MF5VOXVKl4dH5hHH9UguRinF79TdKg3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="425770758" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="425770758" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 06:49:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="682317493" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="682317493" Received: from jball6-mobl.amr.corp.intel.com (HELO [10.209.105.116]) ([10.209.105.116]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 06:49:29 -0700 Message-ID: <141def31-dcbb-70ae-2935-4fb06a986036@intel.com> Date: Thu, 23 Mar 2023 06:49:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 05/16] x86/virt/tdx: Add skeleton to enable TDX on demand Content-Language: en-US To: "Huang, Kai" , "isaku.yamahata@gmail.com" Cc: "kvm@vger.kernel.org" , "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "kirill.shutemov@linux.intel.com" , "linux-mm@kvack.org" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <20230308222738.GA3419702@ls.amr.corp.intel.com> <96b56c5b8a5876aaf6d5ccbb81bab334b10983eb.camel@intel.com> <20230313234916.GC3922605@ls.amr.corp.intel.com> <5c4a28c8-f17d-7395-cc63-3cbd9b31befb@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7DA8640012 X-Stat-Signature: mnry6rbrs9788kmyy6z8t8qb64uqz4b5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679579383-468350 X-HE-Meta: U2FsdGVkX1+VNqrECcdak2UMbk0QFG5fmgu0/MA9x+hAmTsjv26L8GPctDUp+5aTD76zy1eYzBIavu0MWr6yLz2VhwtMzR3xDkttWf5GU1B2/36BEpkm2DyZXLwVrNOM/wWweYpMn7Nx5nVUCwCVRTRsu1/N1qVMqNHQ4Yvk+ENsRc+f+SacGCoh1XOisuE7eShlglJ3fWOjyDVprHJZlJvebdVlo/Ao2t/kn/JRGJ0JquW/BbW0fylmPG2rrX26DPc35UBIz9VV1xpQCsNy0CdweMtcqArIMLy8MJGawPbTA9M49w7J6/sgoWr5faOAj95o97GTbi87n9+aq0T5qjizyAgpc8q8Q4ul39e2U+0aWrOMGutycC5i893ucruEEfrNh+8tUsfuTRsrnJ1st7Jg7rqyK78dUVKgaFACBi/nhLFF0porEVSSPCepBhxeQ9Sdn7Iv9nyA6SIpC/8d1AJnLCoYsF1f0Qcd1luufG7Os5kGuvXABm4tsYxicl1ve9HLxJvAtWXwQvaSdM2+Qq4ei/G1lJBnFsiSObT+tVu/wnBw+2x/NIpF+ln8JXAGweajjnFikbOrrbN5KJe+zPUqueYi/cARbyZ381yTCHKWY7pgUQoFBiFDAY4UjuRsyfYGtGSXG94Wj3iivncp8VuaT4AMC/Y0sbpUwdDPok6zYWN2o8GC+yhSHi16Sfv0docbCH3/4TGPyDR8UX3qAVN7LnyIxUmbefk4NunMelU3RqUs5CvRkJkf/j2MwS0Lop3QaOjAJEVpWQKor0Iq8K5OKaE29WiYW/N3+s6fO9dpkakKOt5oS2Y7CQ/lVRXn/ZGu7y+xMcnHUwhAJhBtKaZSzjZ/EQ2vHeoN8YkLF1MuXznLFEVrClhYtME3xUcIbDlIBDWIdJAk84byunLUTMfop1GYYUefg36oouK0BzaXMgdJxj8rhx89h8g1XzQF0f/yYgo6qUdOvg3TE9u TY7ZmfRl eG+W7Wtx/efzg6kvjB10PpmcXKEIov4H5ylBS35LOB0cjkkJVdRvzF7HA1hZRRnjWOZpFozqhVfyvzlaYuqsAGkyudv0mK4F2nlrK1LduqbYAKmuiXiH2GSwQ3HT6tHRgJf91uSmuK0KbqRtQ95ev4WWwGZ3EUG6VIy138gGVqS6lnTMwkAmdewIGV/7zv4RuvG3yOZsqjl1YXv8mfjCCETBMIxBCp0iHKkr65/pb9yxNGhuFpvAmnzN6iGIiifvrS/waJZnAnXh5wPr/aLYFo1XhDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 04:10, Huang, Kai wrote: > I can do. Just want to make sure do you want to retry TDX_SYS_BUSY, or retry > TDX_RND_NO_ENTROPY (if we want to ask TDX module guys to change to return this > value)? I'll put it this way: Linux is going to treat TDX_SYS_BUSY like a Linux bug and assume Linux is doing something wrong. It'll mostly mean that users will see something nasty and may even cause Linux to give up on TDX. In other words, the TDX module shouldn't use TDX_SYS_BUSY for things that aren't Linux's fault. > Also, even we retry either TDX_SYS_BUSY or TDX_RND_NO_ENTROPY in common > seamcall() code, it doesn't handle the TDH.SYS.KEY.CONFIG, because sadly this > SEAMCALL returns a different error code: > > TDX_KEY_GENERATION_FAILED Failed to generate a random key. This is > typically caused by an entropy error of the > CPU's random number generator, and may > be impacted by RDSEED, RDRAND or PCONFIG > executing on other LPs. The operation should be > retried. Sounds like we should just replace TDX_KEY_GENERATION_FAILED with TDX_RND_NO_ENTROPY in cases where key generation fails because of a lack of entropy.