From: Chintan Pandya <cpandya@codeaurora.org>
To: mhocko@suse.cz, hannes@cmpxchg.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Chintan Pandya <cpandya@codeaurora.org>
Subject: [PATCH] memcg: Provide knob for force OOM into the memcg
Date: Tue, 16 Dec 2014 18:55:35 +0530 [thread overview]
Message-ID: <1418736335-30915-1-git-send-email-cpandya@codeaurora.org> (raw)
We may want to use memcg to limit the total memory
footprint of all the processes within the one group.
This may lead to a situation where any arbitrary
process cannot get migrated to that one memcg
because its limits will be breached. Or, process can
get migrated but even being most recently used
process, it can get killed by in-cgroup OOM. To
avoid such scenarios, provide a convenient knob
by which we can forcefully trigger OOM and make
a room for upcoming process.
To trigger force OOM,
$ echo 1 > /<memcg_path>/memory.force_oom
Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
---
mm/memcontrol.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index ef91e85..4c68aa7 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3305,6 +3305,30 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg)
return 0;
}
+static int mem_cgroup_force_oom(struct cgroup *cont, unsigned int event)
+{
+ struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
+ int ret;
+
+ if (mem_cgroup_is_root(memcg))
+ return -EINVAL;
+
+ css_get(&memcg->css);
+ ret = mem_cgroup_handle_oom(memcg, GFP_KERNEL, 0);
+ css_put(&memcg->css);
+
+ return ret;
+}
+
+static int mem_cgroup_force_oom_write(struct cgroup *cgrp,
+ struct cftype *cft, u64 val)
+{
+ if (val > 1 || val < 1)
+ return -EINVAL;
+
+ return mem_cgroup_force_oom(cgrp, 0);
+}
+
static ssize_t mem_cgroup_force_empty_write(struct kernfs_open_file *of,
char *buf, size_t nbytes,
loff_t off)
@@ -4442,6 +4466,11 @@ static struct cftype mem_cgroup_files[] = {
.write = mem_cgroup_force_empty_write,
},
{
+ .name = "force_oom",
+ .trigger = mem_cgroup_force_oom,
+ .write_u64 = mem_cgroup_force_oom_write,
+ },
+ {
.name = "use_hierarchy",
.write_u64 = mem_cgroup_hierarchy_write,
.read_u64 = mem_cgroup_hierarchy_read,
--
Chintan Pandya
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-12-16 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 13:25 Chintan Pandya [this message]
2014-12-16 13:39 ` Michal Hocko
2014-12-16 22:33 ` David Rientjes
2014-12-17 11:47 ` Chintan Pandya
2014-12-16 16:59 ` Johannes Weiner
2014-12-17 12:11 ` Chintan Pandya
2014-12-19 21:15 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418736335-30915-1-git-send-email-cpandya@codeaurora.org \
--to=cpandya@codeaurora.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox