From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) by kanga.kvack.org (Postfix) with ESMTP id B10786B00E3 for ; Wed, 12 Nov 2014 03:38:01 -0500 (EST) Received: by mail-pd0-f176.google.com with SMTP id ft15so11769881pdb.35 for ; Wed, 12 Nov 2014 00:38:01 -0800 (PST) Received: from heian.cn.fujitsu.com ([59.151.112.132]) by mx.google.com with ESMTP id 1si22318631pdr.58.2014.11.12.00.37.58 for ; Wed, 12 Nov 2014 00:38:00 -0800 (PST) From: Tang Chen Subject: [PATCH v3 0/2] Fix node meminfo and zoneinfo corruption. Date: Wed, 12 Nov 2014 16:37:12 +0800 Message-ID: <1415781434-20230-1-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org, grygorii.strashko@ti.com, yinghai@kernel.org, isimatu.yasuaki@jp.fujitsu.com, fabf@skynet.be, nzimmer@sgi.com, wangnan0@huawei.com, vdavydov@parallels.com, toshi.kani@hp.com, phacht@linux.vnet.ibm.com, tj@kernel.org, kirill.shutemov@linux.intel.com, riel@redhat.com, luto@amacapital.net, hpa@linux.intel.com, aarcange@redhat.com, qiuxishi@huawei.com, mgorman@suse.de, rientjes@google.com, hannes@cmpxchg.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, tangchen@cn.fujitsu.com There are two problems in memory hot-add progress: 1. When hot-adding a node without onlining any page, node meminfo corrupted: # hot-add node2 (memory not onlined) # cat /sys/device/system/node/node2/meminfo Node 2 MemTotal: 33554432 kB /* corrupted */ Node 2 MemFree: 0 kB Node 2 MemUsed: 33554432 kB Node 2 Active: 0 kB ...... 2. When onlining memory on node2, node2 zoneinfo and node3 meminfo corrupted: # for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done # cat /sys/devices/system/node/node2/meminfo Node 2 MemTotal: 33554432 kB Node 2 MemFree: 33549092 kB Node 2 MemUsed: 5340 kB ...... # cat /sys/devices/system/node/node3/meminfo Node 3 MemTotal: 0 kB Node 3 MemFree: 248 kB /* corrupted, should be 0 */ Node 3 MemUsed: 0 kB ...... # cat /proc/zoneinfo ...... Node 2, zone Movable ...... spanned 8388608 present 16777216 /* corrupted, should be 8388608 */ managed 8388608 Change log v2 -> v3: 1. Also clear pgdat->node_present_pages in patch 2/2. 2. Add Cc: stable@vger.kernel.org # 3.16+ since it is urgent. Change log v1 -> v2: 1. Replace patch 2/2 with a new one. It provides the simplest way to fix problem 2. Tang Chen (2): mem-hotplug: Reset node managed pages when hot-adding a new pgdat. mem-hotplug: Reset node present pages when hot-adding a new pgdat. include/linux/bootmem.h | 1 + mm/bootmem.c | 9 +++++---- mm/memory_hotplug.c | 26 ++++++++++++++++++++++++++ mm/nobootmem.c | 8 +++++--- 4 files changed, 37 insertions(+), 7 deletions(-) -- 1.8.3.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org