From: Davidlohr Bueso <dave@stgolabs.net>
To: akpm@linux-foundation.org
Cc: hughd@google.com, riel@redhat.com, mgorman@suse.de,
peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, dbueso@suse.de, linux-mm@kvack.org,
Davidlohr Bueso <dave@stgolabs.net>
Subject: [PATCH 08/10] mm/mremap: share the i_mmap_rwsem
Date: Fri, 24 Oct 2014 15:06:18 -0700 [thread overview]
Message-ID: <1414188380-17376-9-git-send-email-dave@stgolabs.net> (raw)
In-Reply-To: <1414188380-17376-1-git-send-email-dave@stgolabs.net>
As per the comment in move_ptes(), we only require taking the
anon vma and i_mmap locks to ensure that rmap will always observe
either the old or new ptes, in the case of need_rmap_lock=true.
No modifications to the tree itself, thus share the i_mmap_rwsem.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
XXX: the same *should* apply for the anon vma, as there are
no modifications to the chain.
mm/mremap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/mremap.c b/mm/mremap.c
index 84aa36f..a34500c 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -119,7 +119,7 @@ static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd,
if (need_rmap_locks) {
if (vma->vm_file) {
mapping = vma->vm_file->f_mapping;
- i_mmap_lock_write(mapping);
+ i_mmap_lock_read(mapping);
}
if (vma->anon_vma) {
anon_vma = vma->anon_vma;
@@ -156,7 +156,7 @@ static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd,
if (anon_vma)
anon_vma_unlock_write(anon_vma);
if (mapping)
- i_mmap_unlock_write(mapping);
+ i_mmap_unlock_read(mapping);
}
#define LATENCY_LIMIT (64 * PAGE_SIZE)
--
1.8.4.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-24 22:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 22:06 [PATCH 00/10] mm: improve usage of the i_mmap lock Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 01/10] mm,fs: introduce helpers around the i_mmap_mutex Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 02/10] mm: use new helper functions " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 03/10] mm: convert i_mmap_mutex to rwsem Davidlohr Bueso
2014-10-24 22:45 ` Kirill A. Shutemov
2014-10-28 20:27 ` Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 04/10] mm/rmap: share the i_mmap_rwsem Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 05/10] uprobes: " Davidlohr Bueso
2014-10-27 7:03 ` Srikar Dronamraju
2014-10-28 2:02 ` Oleg Nesterov
2014-10-24 22:06 ` [PATCH 06/10] mm/xip: " Davidlohr Bueso
2014-10-24 22:06 ` [PATCH 07/10] mm/memory-failure: " Davidlohr Bueso
2014-10-24 22:06 ` Davidlohr Bueso [this message]
2014-10-24 22:06 ` [PATCH 09/10] mm/nommu: " Davidlohr Bueso
2014-10-24 22:16 ` [PATCH 10/10] mm/hugetlb: " Davidlohr Bueso
2014-10-28 14:08 ` [PATCH 00/10] mm: improve usage of the i_mmap lock Kirill A. Shutemov
2014-10-30 19:34 [PATCH v2 -next " Davidlohr Bueso
2014-10-30 19:34 ` [PATCH 08/10] mm/mremap: share the i_mmap_rwsem Davidlohr Bueso
2014-11-04 6:04 ` Hugh Dickins
2014-11-04 12:29 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414188380-17376-9-git-send-email-dave@stgolabs.net \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox