From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0204C433F5 for ; Mon, 7 Mar 2022 11:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 170DE8D0002; Mon, 7 Mar 2022 06:46:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 121418D0001; Mon, 7 Mar 2022 06:46:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00F8B8D0002; Mon, 7 Mar 2022 06:46:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E35398D0001 for ; Mon, 7 Mar 2022 06:46:41 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AE2642440B for ; Mon, 7 Mar 2022 11:46:41 +0000 (UTC) X-FDA: 79217413002.09.FF462F7 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id 8CFE840004 for ; Mon, 7 Mar 2022 11:46:40 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KBxPp6jPqzbc9C; Mon, 7 Mar 2022 19:41:50 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 7 Mar 2022 19:46:36 +0800 Subject: Re: [PATCH 13/16] mm/migration: return errno when isolate_huge_page failed To: Muchun Song CC: Andrew Morton , Mike Kravetz , Yang Shi , Matthew Wilcox , Huang Ying , Zi Yan , Minchan Kim , Alistair Popple , , , Mina Almasry , John Hubbard , Ralph Campbell , Peter Xu , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Michal Hocko , , Linux Memory Management List , LKML References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-14-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <1412b4e5-b76e-f827-6505-5dcae48caabd@huawei.com> Date: Mon, 7 Mar 2022 19:46:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8CFE840004 X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: ugijb8gua4jnbqsa1h5xcb7hkbabgneb X-HE-Tag: 1646653600-99891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/5 10:23, Muchun Song wrote: > On Fri, Mar 4, 2022 at 5:36 PM Miaohe Lin wrote: >> >> We should return errno (-EBUSY here) when failed to isolate the huge page >> rather than always return 1 which could confuse the user. >> >> Signed-off-by: Miaohe Lin > > IIUC, this should be a bug fix since the status reported to the user is > wrong. A Fixes tag may be needed. But anyway: > Agree. Thanks for pointing this out and many thanks for your review. :) > Reviewed-by: Muchun Song > > Thanks. > > . >